Skip to content

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented May 3, 2023

This is a re-creation of this older PR. Somehow, git stash became an author of a commit on the old pr, which was then parsed as an actual person, and that actual person has not signed the CLA. Rebasing the 60+ commits on top of that old commit to amend the author was prohibitively hard, and so I've squashed the old commits into a new branch (if any git experts are aware of an easier fix for this please let me know!).

Old pr description:
This PR implements video capture for the CameraX re-write of the android camera plugin.

flutter/flutter#111138

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall requested a review from reidbaker May 3, 2023 19:55
@gmackall
Copy link
Member Author

gmackall commented May 4, 2023

Closing this as we pushed this resolved git history to the original branch, updating the original PR.

git push --force-with-lease origin video_cla_fix:video_capture

@gmackall gmackall closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant