Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[various] Remove unnecessary null checks #4060

Merged
merged 9 commits into from
May 22, 2023
Merged

[various] Remove unnecessary null checks #4060

merged 9 commits into from
May 22, 2023

Conversation

stuartmorgan
Copy link
Contributor

Removes unnecessary_null_comparison: ignore from the repository analysis options. Now that Dart 3 has reached the stable channel, all fully supported customers will be running in strong mode, so the extra null checks are no longer needed. While many packages do support earlier versions, this won't break anyone, it will just mean that people who are both a) using old versions of Flutter and b) violating the API contract by passing null to a non-nullable type, won't get error messages that are as obvious, which is fine for the best-effort support level we give to pre-current-stable versions of Flutter.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan stuartmorgan requested a review from chunhtai as a code owner May 22, 2023 15:22
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 22, 2023

auto label is removed for flutter/packages, pr: 4060, due to - The status or check suite Windows win32-platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

cbracken
cbracken approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2023
@auto-submit auto-submit bot merged commit d449a17 into flutter:main May 22, 2023
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request May 23, 2023
Merge branch 'main' into webview_patchedv5
a3ba9c3 
* main: (104 commits)
  [various] Remove unnecessary null checks (flutter#4060)
  [ci] Add a legacy Android build-all test (flutter#4005)
  Roll Flutter from ab57304 to 3437189 (5 revisions) (flutter#4062)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [in_app_purchases] Fix mismatching method signature strings (flutter#4040)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  Roll Flutter from 077d644 to ab57304 (18 revisions) (flutter#4051)
  Roll Flutter from 5ae6438 to 077d644 (23 revisions) (flutter#4043)
  [local_auth] Migrate iOS to Pigeon (flutter#3974)
  [go_router] fix context extension for replaceNamed (flutter#3927)
  [image_picker] Fix crash due to `SecurityException` (flutter#4004)
  Roll Flutter from d0d1feb to 5ae6438 (42 revisions) (flutter#4038)
  [ci] Lower iOS LUCI timeouts (flutter#4035)
  [ci] Increase Android sharding (flutter#4029)
  [flutter_plugin_android_lifecycle] Fix lints (flutter#4030)
  [rfw] Fix a typo in the API documentation (flutter#4023)
  ...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023
@engine-flutter-autoroll
d449a17 [various] Remove unnecessary null checks (flutter/packages#4060)
32b1e3f
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 23, 2023
@engine-flutter-autoroll
Roll Packages from 83959fb to d449a17 (6 revisions) (#127394)
20ccf09 
flutter/packages@83959fb...d449a17

2023-05-22 stuartmorgan@google.com [various] Remove unnecessary null checks (flutter/packages#4060)
2023-05-22 stuartmorgan@google.com [ci] Add a legacy Android build-all test (flutter/packages#4005)
2023-05-22 engine-flutter-autoroll@skia.org Roll Flutter from ab57304 to 3437189 (5 revisions) (flutter/packages#4062)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@stuartmorgan stuartmorgan deleted the analysis-options-null-check branch May 23, 2023 18:06
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 83959fb to d449a17 (6 revisions) (flutter#127394)
b3ee03c 
flutter/packages@83959fb...d449a17

2023-05-22 stuartmorgan@google.com [various] Remove unnecessary null checks (flutter/packages#4060)
2023-05-22 stuartmorgan@google.com [ci] Add a legacy Android build-all test (flutter/packages#4005)
2023-05-22 engine-flutter-autoroll@skia.org Roll Flutter from ab57304 to 3437189 (5 revisions) (flutter/packages#4062)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
JSUYA added a commit to JSUYA/plugins that referenced this pull request Mar 6, 2024
@JSUYA
Sync with analysis_options.yaml in flutter/packages
2150d03 
Some packages require package upgrade rather than simple modification
(ex: google_maps_flutter) Therefore, the rules below are temporarily ignored.
Any necessary modifications can be applied in a later PR.

flutter/packages#4060
- unnecessary_null_comparison

flutter/packages#4067
- unawaited_futures

flutter/packages#5717
- dangling_library_doc_comments
- no_literal_bool_comparisons
- unnecessary_library_directive
- use_colored_box
- use_enums
- use_string_in_part_of_directives
@JSUYA JSUYA mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@cbracken cbracken cbracken approved these changes

@domesticmouse domesticmouse domesticmouse approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@yjbanov yjbanov Awaiting requested review from yjbanov yjbanov is a code owner

@keyonghan keyonghan Awaiting requested review from keyonghan

@Piinks Piinks Awaiting requested review from Piinks

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera p: dynamic_layouts The dynamic_layouts package p: flutter_markdown p: flutter_migrate p: go_router p: google_maps_flutter p: google_sign_in p: in_app_purchase p: ios_platform_images p: metrics_center p: path_provider p: quick_actions p: url_launcher p: web_benchmarks p: webview_flutter platform-android platform-ios platform-linux platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartmorgan @domesticmouse @cbracken @reidbaker