Ignore textScaleFactor deprecation
#4209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
commented
Jun 14, 2023
| softWrap: source.v<bool>(['softWrap']), | ||
| overflow: ArgumentDecoders.enumValue<TextOverflow>(TextOverflow.values, source, ['overflow']), | ||
| textScaleFactor: source.v<double>(['textScaleFactor']), | ||
| textScaleFactor: source.v<double>(['textScaleFactor']), // ignore: deprecated_member_use |
Contributor
Author
There was a problem hiding this comment.
I wonder how this is going to be migrated, since textScaler is essentially a function?
Contributor
There was a problem hiding this comment.
would something like textScaler: TextScaler.linear(source.v<double>(['textScaleFactor'])) work?
Contributor
Author
|
Not sure if version changes are needed? |
domesticmouse
approved these changes
Jun 14, 2023
LongCatIsLooong
added
override: no versioning needed
Contributor
Author
|
No version change or change log: disabling the lint rule for a framework deprecation |
LongCatIsLooong
added
the
autosubmit
Contributor
|
LGTM for the rfw changes. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 16, 2023
flutter/packages@f9314a3...59d93d6 2023-06-16 stuartmorgan@google.com [tool] Add command aliases (flutter/packages#4207) 2023-06-16 stuartmorgan@google.com [google_map_flutter] Fix map object regression due to async changes (flutter/packages#4171) 2023-06-16 goderbauer@google.com [url_launcher] Add ignores for deprecated member to test (flutter/packages#4220) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter from 95be76a to b0188cd (10 revisions) (flutter/packages#4221) 2023-06-15 34871572+gmackall@users.noreply.github.com [camera_android] Upgrading roboelectric from 4.5 to 4.10.3 (flutter/packages#4018) 2023-06-15 47866232+chunhtai@users.noreply.github.com [go_router] Fixes bug that GoRouterState in top level redirect doesn'� (flutter/packages#4173) 2023-06-15 47866232+chunhtai@users.noreply.github.com [go_router]Updates documentations around GoRouter.of, GoRouter.maybeOf, and BuildContext extension. (flutter/packages#4176) 2023-06-15 stuartmorgan@google.com [tool] Support code excerpts for any .md file (flutter/packages#4212) 2023-06-15 baptiste.dupuch@gmail.com [webview_flutter] Add support for limitsNavigationsToAppBoundDomains (flutter/packages#4026) 2023-06-15 yk3372@gmail.com [webview_flutter][webview_flutter_android] Add android support for handling geolocation permissions (flutter/packages#3795) 2023-06-15 tarrinneal@gmail.com [image_picker] add getMedia method (flutter/packages#3892) 2023-06-15 tarrinneal@gmail.com [image_picker] getMedia platform implementations (flutter/packages#4175) 2023-06-14 31859944+LongCatIsLooong@users.noreply.github.com Ignore `textScaleFactor` deprecation (flutter/packages#4209) 2023-06-14 stuartmorgan@google.com [pigeon] Enable Obj-C integration tests in CI (flutter/packages#4215) 2023-06-14 63286031+ahmednfwela@users.noreply.github.com [flutter_adaptive_scaffold] Support RTL (flutter/packages#4204) 2023-06-14 engine-flutter-autoroll@skia.org Manual roll Flutter from 09b7e56 to 95be76a (14 revisions) (flutter/packages#4214) 2023-06-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 682aa38 to 796c8ef (5 revisions) (flutter/packages#4213) 2023-06-14 engine-flutter-autoroll@skia.org Roll Flutter from 353b8bc to 09b7e56 (17 revisions) (flutter/packages#4206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 17, 2023
#4209 missed a few deprecations since it was reformatted and the "ignore" was placed on the incorrect lines. Now `dart analyze --fatal-infos` says no issues found.
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore
textScaleFactordeprecation, as suggested in flutter/flutter#128825Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.