Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css_colors] docs: Update deprecated link address #4537

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

betternormal
Copy link
Contributor

@betternormal betternormal commented Jul 21, 2023

Update the Color class's official documentation URL in the README.md of the css_colors package.

List which issues are fixed by this PR. You must list at least one issue.

  • Correct the address of the incorrect hyperlink

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Jul 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@stuartmorgan
Copy link
Contributor

Thanks for the contribution! Please let me know when these steps have been completed, then I can proceed with the review:

@betternormal
Copy link
Contributor Author

betternormal commented Jul 23, 2023

Thanks for the contribution! Please let me know when these steps have been completed, then I can proceed with the review:

Thank you for your response! I have completed the following items:

  • I added the description to the "next" section of the CHANGELOG.md
  • I checked that the pubspec.yaml is updated to the latest Dart version

@stuartmorgan
Copy link
Contributor

  • I checked that the pubspec.yaml is updated to the latest Dart version

I'm not sure what this means exactly, but the checklist item is about updating the package version.

@betternormal
Copy link
Contributor Author

  • I checked that the pubspec.yaml is updated to the latest Dart version

I'm not sure what this means exactly, but the checklist item is about updating the package version.

Thank you for your response. I updated the package version

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Jul 23, 2023

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 24, 2023

auto label is removed for flutter/packages/4537, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@stuartmorgan
Copy link
Contributor

@tarrinneal could you do the secondary review on this quick PR?

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 29, 2023
flutter/packages@383bffa...d7d3150

2023-08-29 ian@hixie.ch [rfw] Implement /* block comments */ in the text format (flutter/packages#4769)
2023-08-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.4 to 2.21.5 (flutter/packages#4810)
2023-08-28 engine-flutter-autoroll@skia.org Roll Flutter from cd3aeef to ec387a4 (15 revisions) (flutter/packages#4807)
2023-08-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.0 to 1.9.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4798)
2023-08-28 jhy03261997@gmail.com Fix  popping repeated pages unexpectedly (flutter/packages#4763)
2023-08-28 tarrinneal@gmail.com [pigeon] primitive enums (flutter/packages#4580)
2023-08-27 engine-flutter-autoroll@skia.org Roll Flutter from 229b74d to cd3aeef (4 revisions) (flutter/packages#4777)
2023-08-26 engine-flutter-autoroll@skia.org Roll Flutter from 61d9f55 to 229b74d (13 revisions) (flutter/packages#4776)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter from deeb811 to 61d9f55 (25 revisions) (flutter/packages#4774)
2023-08-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/packages#4770)
2023-08-24 praconfi@gmail.com [css_colors] docs: Update deprecated link address (flutter/packages#4537)
2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter (stable) from efbf63d to e1e4722 (3 revisions) (flutter/packages#4767)
2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter from bd836cc to deeb811 (17 revisions) (flutter/packages#4766)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: css_colors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants