-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter] Adds option to register JavaScript console callback #4541
Closed
mvanbeusekom
wants to merge
24
commits into
flutter:main
from
Baseflow:feature/forward_javascript_console
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5b3f013
Adds JavaScript console override on WKWebView
mvanbeusekom 2a388de
Adds JavaScript console override on WKWebView
mvanbeusekom 3aa11af
Fix setConsoleLogCallback unit-test
mvanbeusekom 0b08773
Fix analyze warning
mvanbeusekom fe22549
Adds the JavaScript info loglevel
mvanbeusekom 0c45243
Fix integration test and dependencies
mvanbeusekom 94775bb
wrap onConsoleMessage
bparrishMines d6b0600
Adds console log callback to Android and App facing packages
mvanbeusekom 2eee568
Fixed formatting
mvanbeusekom e21cd64
Adds missing license block
mvanbeusekom e9b0f3d
Update packages/webview_flutter/webview_flutter_wkwebview/lib/src/web…
mvanbeusekom 42b1210
Update packages/webview_flutter/webview_flutter_wkwebview/lib/src/web…
mvanbeusekom 2a4dc3f
Merge remote-tracking branch 'upstream/main' into feature/forward_jav…
mvanbeusekom dafed42
Apply PR feedback
mvanbeusekom 9e7fed2
Merge branch 'feature/forward_javascript_console' of github.com:basef…
mvanbeusekom de2a099
Apply PR feedback
mvanbeusekom 6759419
Merge branch 'main' into feature/forward_javascript_console
mvanbeusekom 4482d9a
Map TIP to JavaScriptConsoleLevel.debug
mvanbeusekom 0a4f984
Merge branch 'feature/forward_javascript_console' of github.com:basef…
mvanbeusekom 9b02117
Fix formatting and analyze warning
mvanbeusekom 94ec766
Merge branch 'main' into feature/forward_javascript_console
mvanbeusekom 56b2a5e
Generate updates test mocks
mvanbeusekom 07f68b2
Merge branch 'main' of https://github.com/flutter/packages into featu…
mvanbeusekom 4910c2e
Merge branch 'feature/forward_javascript_console' of github.com:basef…
mvanbeusekom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
packages/webview_flutter/webview_flutter/test/legacy/webview_flutter_test.mocks.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
packages/webview_flutter/webview_flutter/test/webview_cookie_manager_test.mocks.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/webview_flutter/webview_flutter_android/CHANGELOG.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to include this info in the
app-facing
package since this is already included in thewebview_flutter_wkebview
implementation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means that the documentation will not show up in the IDE of developers calling the method. I put it here on purpose so developers setting the method are clearly informed.