Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[video_player] Add optional web options [web] #4551

Merged
merged 13 commits into from
Sep 7, 2023
Merged

[video_player] Add optional web options [web] #4551

merged 13 commits into from
Sep 7, 2023

Conversation

defuncart
Copy link
Contributor

Web PR for Video Player Web Options (#3259).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@defuncart defuncart requested a review from ditman as a code owner July 23, 2023 10:09
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@defuncart
Copy link
Contributor Author

@ditman @stuartmorgan Web PR for #3259.

@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-web-package branch 3 times, most recently from c89c8e7 to 2175f44 Compare July 24, 2023 05:32
@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-web-package branch from 2175f44 to a2b2329 Compare July 25, 2023 06:29
@defuncart defuncart requested a review from ditman July 25, 2023 06:29
@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-web-package branch from a2b2329 to bfc2d6d Compare July 27, 2023 05:39
@defuncart defuncart requested a review from ditman July 27, 2023 05:40
@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-web-package branch from bfc2d6d to d740422 Compare July 29, 2023 09:07
ditman
ditman reviewed Aug 3, 2023
View reviewed changes
packages/video_player/video_player_web/CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
## NEXT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## NEXT
## 2.1.0

This needs to be published to be usable, right? If so, we want to bump the version to 2.1.0, here and in the pubspec.yaml of the package!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Done)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the history since this PR has been force-pushed, but it looks like you undid an existing change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan Apologies, added back 688077f

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual package version bump is still reverted, as indicated by CI.

ditman
ditman approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I think this is ready to land. Second opinion, @stuartmorgan?

stuartmorgan
stuartmorgan approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits.

packages/video_player/video_player_web/lib/src/video_player.dart Outdated Show resolved Hide resolved
packages/video_player/video_player_web/pubspec.yaml Outdated Show resolved Hide resolved
@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-web-package branch from 47503fb to dff9524 Compare August 8, 2023 08:01
@defuncart
Copy link
Contributor Author

@stuartmorgan @ditman Requested changes pushed :)

stuartmorgan
stuartmorgan requested changes Aug 8, 2023
View reviewed changes
packages/video_player/video_player_web/CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
## NEXT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the history since this PR has been force-pushed, but it looks like you undid an existing change.

@defuncart defuncart requested a review from stuartmorgan August 8, 2023 15:39
@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-web-package branch from 688077f to 150bc52 Compare August 9, 2023 16:42
stuartmorgan
stuartmorgan requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating review state per my comment above; this is failing CI because it doesn't actually contain a version bump.

@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-web-package branch from 150bc52 to 9a1e7ff Compare August 22, 2023 05:54
@defuncart
Copy link
Contributor Author

@ditman @stuartmorgan Please re-reviewed and let me know if anything needs to be changed.

@defuncart defuncart requested a review from stuartmorgan August 22, 2023 05:54
stuartmorgan
stuartmorgan approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR to bump the version, since that was still missing.

LGTM with that change.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2023
@stuartmorgan
Copy link
Contributor

Sorry, looks like I just missed adding the label to this.

@auto-submit auto-submit bot merged commit 8bf9abb into flutter:main Sep 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2023
@engine-flutter-autoroll
8bf9abb [video_player] Add optional web options [web] (flutter/packag…
63a85c8 
…es#4551)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 8, 2023
@engine-flutter-autoroll
Roll Packages from 22d4754 to aaae5ef (7 revisions) (#134301)
53017f8 
flutter/packages@22d4754...aaae5ef

2023-09-08 43054281+camsim99@users.noreply.github.com [tool] Add Android dependency (gradle) option to update dependencies command (flutter/packages#4757)
2023-09-08 43054281+camsim99@users.noreply.github.com [camerax] Implement resolution configuration (flutter/packages#3799)
2023-09-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 685ce14 to aea4552 (64 revisions) (flutter/packages#4870)
2023-09-07 ditman@gmail.com [rfw, ci] Regenerate goldens, manually roll #4835 (flutter/packages#4862)
2023-09-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.0.0 (flutter/packages#4845)
2023-09-07 defuncart@gmail.com [video_player] Add optional web options [web] (flutter/packages#4551)
2023-09-07 me@nils.re [flutter_markdown] Remove `ignore: avoid_init_to_null` since the package uses Dart 3 (flutter/packages#4852)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman ditman approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: video_player platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@defuncart @stuartmorgan @ditman