[fuchsia_ctl] Fix IPv6 URL formatting for amber_ctl #46
Conversation
If the local address of the interface that's connected to the Fuchsia device has an IPv6 address the URL to the Amber config.json was formatted incorrectly.
ianloic
requested review from
cbracken,
zanderso,
dnfield,
jonahwilliams and
godofredoc
| /// | ||
| /// Calling this before calling [serveRepo] will result in a [StateError]. | ||
| String sourceUrl(String localIp) { | ||
| if (localIp.contains(':')) { |
There was a problem hiding this comment.
Did we validated this fixes the problem locally?
There was a problem hiding this comment.
Nope. And actually, I think it's wrong...
There was a problem hiding this comment.
Maybe try https://api.dartlang.org/stable/2.6.1/dart-io/InternetAddress-class.html and get the type from it?
There was a problem hiding this comment.
I tried that but InternetAddress fails to parse IPv6 link local addresses. Additionally we need the link local address from the perspective of the Fuchsia device, not the host. I'm working on an update to this PR that actually does that.
There was a problem hiding this comment.
When I ran locally " amberctl add_src" I just added the ipv6 + interface name from the host which is connected to the devices network and it worked. The device was able to access the amber server.
Devices in the lab are connected to a similar network setup " a nuc(host) with two interfaces one for internet access/lab network access and another one for internal nat network. The device is connected to the nat network. I think eno2 should work
There was a problem hiding this comment.
It may work but I think it's incorrect. With the second commit in this PR I've made the logic match that in fx add-update-source.
|
I think this is right now. PTAL. |
If the local address of the interface that's connected to the Fuchsia
device has an IPv6 address the URL to the Amber config.json was
formatted incorrectly.