Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Update minimums for 3.13 stable #4731

Merged
merged 5 commits into from
Aug 17, 2023
Merged

[ci] Update minimums for 3.13 stable #4731

merged 5 commits into from
Aug 17, 2023

Conversation

stuartmorgan
Copy link
Contributor

  • Updates the N-1 and N-2 analysis bot configs to 3.7 and 3.10
  • Updates the minimum allowed SDK to 3.7, since that's now the earliest we have any testing for.
  • Updates all packages to Flutter 3.7/Dart 2.19 as a minimum.
    • In packages where we hadn't released since the last minimum version bump, I removed the previous line from the #NEXT section to make it less confusing when we do release.

Per https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version this does not update any package versions.

@stuartmorgan stuartmorgan added the override: no versioning needed Override the check requiring version bumps for most changes label Aug 17, 2023
@stuartmorgan stuartmorgan changed the title [ci] Update minimums for new stable [ci] Update minimums for 3.13 stable Aug 17, 2023
jonahwilliams
jonahwilliams approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan
Copy link
Contributor Author

Reviewers: only @tarrinneal and/or @bparrishMines need to review this.

chunhtai
chunhtai approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tarrinneal
tarrinneal approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a lot of nums

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023
bparrishMines
bparrishMines approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit d92cdf0 into flutter:main Aug 17, 2023
@LongCatIsLooong LongCatIsLooong mentioned this pull request Aug 17, 2023
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
d92cdf0 [ci] Update minimums for 3.13 stable (flutter/packages#4731)
ebadd4e
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
Roll Packages from 3b602e7 to 4c16f3e (3 revisions) (#132848)
5a556f8 
flutter/packages@3b602e7...4c16f3e

2023-08-17 katelovett@google.com [two_dimensional_scrollables] TableView (flutter/packages#4536)
2023-08-17 stuartmorgan@google.com [ci] Update minimums for 3.13 stable (flutter/packages#4731)
2023-08-17 10687576+bparrishMines@users.noreply.github.com Update stable version to efbf63d (flutter/packages#4730)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Aug 18, 2023
Closed
Merged
@stuartmorgan stuartmorgan deleted the stable-3-13-update-mins branch August 29, 2023 19:47
This was referenced Sep 5, 2023
Closed
Merged
auto-submit bot pushed a commit that referenced this pull request Sep 12, 2023
@nilsreichardt
[flutter_markdown] Fix changelog regarding minimum supported SDK vers…
c9fbe4e 
…ion (#4851)

The changelog of the `flutter_markdown` package is a bit confusing. First it says:

> Updates minimum supported SDK version to Flutter 3.10/Dart 3.0

and in the latest update is says

> Updates minimum supported SDK version to Flutter 3.7/Dart 2.19

Just from reading this I would expect that the minimum SDK lowered with the latest update. However, this is not the case.

After a bit of researching, I found this was caused by #4731. The mentioned PR only updates the minimum SDK of the example but not of the package, see: https://github.com/flutter/packages/pull/4731/files#diff-e780ee3aec5fdc10512b452b5464878a11caf22fb23d28f725324308ad243d17R6

Therefore, I clarified the changelog with this PR.

![telegram-cloud-photo-size-2-5456132896298487892-y](https://github.com/flutter/flutter/assets/24459435/c992917a-7eda-4e45-a656-50408a6c8910)

<img width="819" alt="image" src="https://github.com/flutter/flutter/assets/24459435/bee2f046-ea86-45c7-9567-a19949e3e6f8">

Fixes flutter/flutter#134056

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@chunhtai chunhtai chunhtai approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu is a code owner

@vashworth vashworth Awaiting requested review from vashworth

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@reidbaker reidbaker Awaiting requested review from reidbaker reidbaker is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@MitchellGoodwin MitchellGoodwin Awaiting requested review from MitchellGoodwin MitchellGoodwin is a code owner

@yjbanov yjbanov Awaiting requested review from yjbanov yjbanov is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@gspencergoog gspencergoog Awaiting requested review from gspencergoog gspencergoog is a code owner

@dnfield dnfield Awaiting requested review from dnfield

@keyonghan keyonghan Awaiting requested review from keyonghan

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@goderbauer goderbauer Awaiting requested review from goderbauer goderbauer is a code owner

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: animations p: camera p: cross_file p: css_colors p: cupertino_icons p: dynamic_layouts The dynamic_layouts package p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_adaptive_scaffold p: flutter_image p: flutter_lints p: flutter_markdown p: flutter_migrate p: flutter_plugin_android_lifecycle p: flutter_template_images p: go_router_builder p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: metrics_center p: multicast_dns p: palette_generator p: path_provider p: pigeon p: plugin_platform_interface p: pointer_interceptor p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: standard_message_codec p: url_launcher p: video_player p: web_benchmarks p: webview_flutter p: xdg_directories platform-android platform-ios platform-linux platform-macos platform-web platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stuartmorgan @jonahwilliams @bparrishMines @chunhtai @tarrinneal