[pigeon] make objcOptions/cppOptions optional #4756
Conversation
Since objcOptions and cppOptions are nullable, this makes it a bit safer. Could also be moved to the constructor. Just a hotfix for making pigeon_build_runner work without a prefix for objc, as these lines throw a null exception right now, but I made a PR to that plugin too to work around this: rotorgames/pigeon_build_runner#1
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
andreasgangso
changed the title
andreasgangso
changed the title
@andreasgangso If you don't feel like managing the pr (tests, versioning, etc), I can roll this into my latest pr. |
Adds support for enums as parameters and return types. Dart, C++, Java, Kotlin, Objective-C, and swift: Primitive synchronous non-null Primitive synchronous nullable Primitive asynchronous non-null Primitive asynchronous nullable Primitive Flutter api non-null Primitive flutter api nullable Objective-C: Class property nullable Also fixes an issue with nullable enums in classes on objc. This fix required a breaking change that nested all nullable enums in a wrapper class to allow nullability. Also adds the ability to format files before tests run (to make my life better) Also replaces #4756 Also adds objc prefixes to enums fixes: flutter/flutter#87307 fixes: flutter/flutter#118733
|
Closing as changes were added with #4580 |
Since objcOptions and cppOptions are nullable, this makes it a bit safer. Could also be moved to the constructor.
Just a hotfix for making pigeon_build_runner work without a prefix for objc, as these lines throw a null exception right now, but I made a PR to that plugin too to work around this: rotorgames/pigeon_build_runner#1
This is such a minor change and not important enough for me to bother opening an issue.
More a heads up to the pigeon maintainer.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).