Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky #4768

Merged
merged 4 commits into from
Sep 11, 2023
Merged

[google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky #4768

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38b41f9
Added delay to address timing issue with info window display status u…
mossmana Aug 24, 2023
e8aced7
Attempting to fix TODO style
mossmana Aug 24, 2023
7222352
Fixed formatting issue
mossmana Aug 24, 2023
b9a655c
reverted removal of waitForValueMatchingPredicate
mossmana Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ..._maps_flutter/google_maps_flutter_android/example/integration_test/google_maps_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,6 +936,14 @@ void googleMapsTests() {
final ExampleGoogleMapController controller =
await controllerCompleter.future;

await tester.pumpAndSettle();

// TODO(mossmana): Adding this delay addresses
// https://github.com/flutter/flutter/issues/131783. It may be related
// to https://github.com/flutter/flutter/issues/54758 and should be
// re-evaluated when that issue is fixed.
await Future<void>.delayed(const Duration(seconds: 1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this violates our style guide: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#never-check-if-a-port-is-available-before-using-it-never-add-timeouts-and-other-race-conditions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hixie I entirely agree, which is why I posted the following comment flutter/flutter#54758 (comment). It is unfortunately an existing pattern in this particular test and I would like to fix it the proper way, but I believe there's additional prerequisite work to be done first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion in the issue suggests that onCameraIdle may work as a hacky version of the actual "finished loading" callback; have you tried using that here, waiting on a future that completes the first time we get that callback?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the suggestion and onCameraIdle is never called.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan I documented what I tried in https://docs.google.com/document/d/1BPQ4OdlNkNEq5xUt8cp72F4qrZrOVTja4vIxqIvq3X4/edit?usp=sharing. Any other suggestions?


bool iwVisibleStatus =
await controller.isMarkerInfoWindowShown(marker.markerId);
expect(iwVisibleStatus, false);
Expand All @@ -953,9 +961,7 @@ void googleMapsTests() {
await controller.hideMarkerInfoWindow(marker.markerId);
iwVisibleStatus = await controller.isMarkerInfoWindowShown(marker.markerId);
expect(iwVisibleStatus, false);
},
// TODO(camsim99): Fix https://github.com/flutter/flutter/issues/131783.
skip: true);
});

testWidgets('fromAssetImage', (WidgetTester tester) async {
const double pixelRatio = 2;
Expand Down