Skip to content

[two_dimensional_scrollables] Fix repaint boundary override in builder delegate #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2023
Merged

[two_dimensional_scrollables] Fix repaint boundary override in builder delegate #4814

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3365d07
Fix repaint boundary override in builder delegate
Piinks Aug 29, 2023
776cbbf
bump version
Piinks Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/two_dimensional_scrollables/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.0.2

* Fixes override of default TwoDimensionalChildBuilderDelegate.addRepaintBoundaries.

## 0.0.1+1

* Adds pub topics to package metadata.
Expand Down
2 changes: 1 addition & 1 deletion packages/two_dimensional_scrollables/lib/src/table_view/table_delegate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class TableCellBuilderDelegate extends TwoDimensionalChildBuilderDelegate
required int rowCount,
int pinnedColumnCount = 0,
int pinnedRowCount = 0,
super.addRepaintBoundaries = false,
super.addRepaintBoundaries,
required TableViewCellBuilder cellBuilder,
required TableSpanBuilder columnBuilder,
required TableSpanBuilder rowBuilder,
Expand Down
11 changes: 11 additions & 0 deletions packages/two_dimensional_scrollables/test/table_view/table_delegate_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,17 @@ void main() {
expect(delegate.maxXIndex, 4); // columns
});

test('Respects super class default for addRepaintBoundaries', () {
final TableCellBuilderDelegate delegate = TableCellBuilderDelegate(
cellBuilder: (_, __) => cell,
columnBuilder: (_) => span,
rowBuilder: (_) => span,
columnCount: 5,
rowCount: 6,
);
expect(delegate.addRepaintBoundaries, isTrue);
});

test('Notifies listeners & rebuilds', () {
int notified = 0;
TableCellBuilderDelegate oldDelegate;
Expand Down
27 changes: 5 additions & 22 deletions packages/two_dimensional_scrollables/test/table_view/table_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,24 +287,17 @@ void main() {
expect(viewport.mainAxis, Axis.vertical);
// first child
TableVicinity vicinity = const TableVicinity(column: 0, row: 0);
expect(
parentDataOf(viewport.firstChild!).vicinity,
vicinity,
);
TableViewParentData parentData = parentDataOf(
tester.renderObject<RenderBox>(find.byKey(childKeys[vicinity]!)),
viewport.firstChild!,
);
expect(parentData.vicinity, vicinity);
expect(parentData.layoutOffset, Offset.zero);
expect(parentData.isVisible, isTrue);
// after first child
vicinity = const TableVicinity(column: 1, row: 0);
expect(
parentDataOf(viewport.childAfter(viewport.firstChild!)!).vicinity,
vicinity,
);

parentData = parentDataOf(
tester.renderObject<RenderBox>(find.byKey(childKeys[vicinity]!)),
viewport.childAfter(viewport.firstChild!)!,
);
expect(parentData.vicinity, vicinity);
expect(parentData.layoutOffset, const Offset(200, 0.0));
Expand All @@ -317,13 +310,7 @@ void main() {

// last child
vicinity = const TableVicinity(column: 4, row: 4);
expect(
parentDataOf(viewport.lastChild!).vicinity,
vicinity,
);
parentData = parentDataOf(
tester.renderObject<RenderBox>(find.byKey(childKeys[vicinity]!)),
);
parentData = parentDataOf(viewport.lastChild!);
expect(parentData.vicinity, vicinity);
expect(parentData.layoutOffset, const Offset(800.0, 800.0));
expect(parentData.isVisible, isFalse);
Expand All @@ -334,12 +321,8 @@ void main() {
);
// before last child
vicinity = const TableVicinity(column: 3, row: 4);
expect(
parentDataOf(viewport.childBefore(viewport.lastChild!)!).vicinity,
vicinity,
);
parentData = parentDataOf(
tester.renderObject<RenderBox>(find.byKey(childKeys[vicinity]!)),
viewport.childBefore(viewport.lastChild!)!,
);
expect(parentData.vicinity, vicinity);
expect(parentData.layoutOffset, const Offset(600.0, 800.0));
Expand Down