[camera_android] Removes usage of _ambiguate method in example
#4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Why not? Which of the exemptions linked from the checklist would apply here? |
My bad, I updated the version 👍 |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 18, 2023
flutter/packages@bc8c2f2...d4e2454 2023-09-18 me@nils.re [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924) 2023-09-17 engine-flutter-autoroll@skia.org Roll Flutter from e5e36ad to 1b18b13 (8 revisions) (flutter/packages#4940) 2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter from 72b69f9 to e5e36ad (12 revisions) (flutter/packages#4938) 2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891) 2023-09-15 engine-flutter-autoroll@skia.org Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (flutter/packages#4934) 2023-09-15 stuartmorgan@google.com [image_picker] Add missing entitlements to macOS example (flutter/packages#4931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@bc8c2f2...d4e2454 2023-09-18 me@nils.re [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924) 2023-09-17 engine-flutter-autoroll@skia.org Roll Flutter from e5e36ad to 1b18b13 (8 revisions) (flutter/packages#4940) 2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter from 72b69f9 to e5e36ad (12 revisions) (flutter/packages#4938) 2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891) 2023-09-15 engine-flutter-autoroll@skia.org Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (flutter/packages#4934) 2023-09-15 stuartmorgan@google.com [image_picker] Add missing entitlements to macOS example (flutter/packages#4931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…tter#4924) Since the minimum Flutter version for this package is +3.0, we can remove the `_ambiguate` method. Part of flutter/flutter#111841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the minimum Flutter version for this package is +3.0, we can remove the
_ambiguatemethod.Part of flutter/flutter#111841
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.