[video_player] Add macOS support #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested review from
hellohuanlin and
tarrinneal
as code owners
|
The podspec check failure is because the Flutter Pod we lint against is one that we manually publish occasionally just for this, and it hasn't been updated since those APIs were added. I'll need to dig up the instructions on updating it. |
This comment was marked as resolved.
This comment was marked as resolved.
stuartmorgan
force-pushed
the
video-player-macos
branch
from
6626917 to
f49c4bd
Compare
stuartmorgan
force-pushed
the
video-player-macos
branch
from
f49c4bd to
30b5011
Compare
|
Tests should all be green now, so this is fully ready. |
tarrinneal
approved these changes
Sep 26, 2023
packages/video_player/video_player_avfoundation/darwin/Classes/FVPVideoPlayerPlugin.m
Show resolved
Hide resolved
|
Hm, I thought that script change would fix the check_podspecs failure. It looks like I'll need to find another way to force it to get the right version. |
And now it's fine even without the cache clearing 🤷🏻 Maybe just a general CDN propagation issue. |
cbracken
approved these changes
Sep 27, 2023
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 28, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 28, 2023
flutter/packages@21c2ebb...c070b0a 2023-09-28 stuartmorgan@google.com [video_player] Add macOS support (flutter/packages#4982) 2023-09-28 32538273+ValentinVignal@users.noreply.github.com [go_router] Avoid logging when `debugLogDiagnostics` is `false` (flutter/packages#4875) 2023-09-28 stuartmorgan@google.com [tool] Don't lint Flutter shim podspecs (flutter/packages#5007) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This comment was marked as resolved.
This comment was marked as resolved.
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@21c2ebb...c070b0a 2023-09-28 stuartmorgan@google.com [video_player] Add macOS support (flutter/packages#4982) 2023-09-28 32538273+ValentinVignal@users.noreply.github.com [go_router] Avoid logging when `debugLogDiagnostics` is `false` (flutter/packages#4875) 2023-09-28 stuartmorgan@google.com [tool] Don't lint Flutter shim podspecs (flutter/packages#5007) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
Adds macOS support to `video_player`, sharing almost all of the code with iOS. Notes about changes at a high level: - macOS does not have `CADisplayLink` (prior to 14, and even there without all the functionality we need), so this adds macOS compilation branches that use the lower-level `CVDisplayLink` instead. Per the TODO, this code should be extracted later to reduce `ifdef`s in what is already a complicated file. - Adds KVO unregistration on `dealloc` if it wasn't done in `dispose`, since unit tests were crashing on macOS with that. - Temporarily ifdef's out `publish:` for macOS, with a TODO to re-enable it after the next stable. Most of flutter/flutter#41688 Once this lands, the app-facing package will be updated to endorse it for macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds macOS support to
video_player, sharing almost all of the code with iOS.Notes about changes at a high level:
CADisplayLink(prior to 14, and even there without all the functionality we need), so this adds macOS compilation branches that use the lower-levelCVDisplayLinkinstead. Per the TODO, this code should be extracted later to reduceifdefs in what is already a complicated file.deallocif it wasn't done indispose, since unit tests were crashing on macOS with that.publish:for macOS, with a TODO to re-enable it after the next stable.Most of flutter/flutter#41688
Once this lands, the app-facing package will be updated to endorse it for macOS.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).