Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shared_preferences_web] migrate to pkg:web #5414

Merged
merged 4 commits into from
Nov 18, 2023
Merged

[shared_preferences_web] migrate to pkg:web #5414

merged 4 commits into from
Nov 18, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Nov 16, 2023 •
edited by ditman
Loading

This allows this package to be used in a web app compiled to Wasm.

Helps unblock flutter/devtools#6606

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@kevmoo kevmoo requested a review from ditman as a code owner November 16, 2023 19:28
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 16, 2023

@ditman I CANNOT figure out why the tests are failing here. Something is weird with clear

CC @srujzs

@kevmoo kevmoo force-pushed the shared_prefs_web branch 2 times, most recently from f44bb68 to 31528d2 Compare November 17, 2023 21:41
@ditman ditman self-assigned this Nov 18, 2023
@ditman
Copy link
Member

ditman commented Nov 18, 2023

I'll take a quick look!

(Note that we need to wait for this to land: #5425)

@ditman
Copy link
Member

ditman commented Nov 18, 2023

Rebasing and looking at test.

@ditman
Copy link
Member

ditman commented Nov 18, 2023 •
edited
Loading

There's something fishy going on with the "flutter.Bool" key?

It seems that the keys getter may be returning an incomplete list of keys, or foreach finishes going through them before all keys are yielded?

Both calling .toList() or making the implementation of keys synchronous seem to help.

I simplified the implementation, and made sure it doesn't hardcode localStorage ((PS: this looks like a good "helper" for package:web, and not this particular plugin))

ditman
ditman approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2023
@auto-submit auto-submit bot merged commit deddb2c into main Nov 18, 2023
79 checks passed
@auto-submit auto-submit bot deleted the shared_prefs_web branch November 18, 2023 04:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2023
@engine-flutter-autoroll
deddb2c [shared_preferences_web] migrate to pkg:web (flutter/packages…
3a18499 
…#5414)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Nov 20, 2023
@engine-flutter-autoroll
Roll Packages from 07b4b29 to c5443ad (13 revisions) (#138724)
16fc837 
flutter/packages@07b4b29...c5443ad

2023-11-20 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Platform Interface) (flutter/packages#5362)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter from 53a57ad to 6cf9ab0 (31 revisions) (flutter/packages#5426)
2023-11-18 kevmoo@users.noreply.github.com [shared_preferences_web] migrate to pkg:web (flutter/packages#5414)
2023-11-18 stuartmorgan@google.com [ci] Roll minimum allowable Flutter to 3.10 (flutter/packages#5425)
2023-11-18 43054281+camsim99@users.noreply.github.com [path_provider_android]  Run tests on AVDs running Android 34 (flutter/packages#5222)
2023-11-17 tarrinneal@gmail.com [pigeon] isEnum, isClass, fix swift casting, default values, optional method arguments, named method arguments (flutter/packages#5355)
2023-11-17 stuartmorgan@google.com [plugin_platform_interface] Switch mixin to `mixin class` (flutter/packages#5420)
2023-11-17 stuartmorgan@google.com [go_router] Fixes use of `Iterable` (flutter/packages#5421)
2023-11-17 stuartmorgan@google.com [pigeon] Adds `analyzer` 6.x compatibility (flutter/packages#5418)
2023-11-17 stuartmorgan@google.com Update release step to 3.16 (flutter/packages#5416)
2023-11-17 kevmoo@users.noreply.github.com [file_selector_web] migrate to pkg:web (flutter/packages#5413)
2023-11-16 stuartmorgan@google.com [video_player] Improve macOS frame management (flutter/packages#5078)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter from e8c2bb1 to 53a57ad (39 revisions) (flutter/packages#5412)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@kevmoo @HugoOlthof
[shared_preferences_web] migrate to pkg:web (flutter#5414)
0281d5c 
This allows this package to be used in a web app compiled to Wasm.

Helps unblock flutter/devtools#6606
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@kevmoo @arc-yong
[shared_preferences_web] migrate to pkg:web (flutter#5414)
326ff09 
This allows this package to be used in a web app compiled to Wasm.

Helps unblock flutter/devtools#6606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman ditman approved these changes

Assignees

@ditman ditman

Labels
autosubmit Merge PR when tree becomes green via auto submit App p: shared_preferences platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @ditman