[google_maps_flutter] Add support for version 8 of the iOS SDK #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
changed the title
|
It's probably easiest to review this as individual commits; the big commit called "Add iOS 14" is just an exact copy of |
jmagman
approved these changes
Nov 30, 2023
|
I hit some deprecation warning failures in CI that I didn't find locally, and it turns out that it's because locally I only resolved to 8.2 (presumably for cache reasons), but 8.3 added a new API and deprecated the ones it replaced. If we have OOB failures from that happening in the future we could restrict the range in the podspec to only allow minor versions we have tested, rather than just major ones, but AFAIK it's never hit us before so for now I'll err on the side of keeping a lenient range. |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 4, 2023
flutter/packages@bc72d15...5d9874f 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter from 918e336 to d861ce4 (29 revisions) (flutter/packages#5542) 2023-12-02 ditman@gmail.com [gsi_web] Do not initialize CodeClient if scopes are empty. (flutter/packages#5537) 2023-12-01 15619084+vashworth@users.noreply.github.com Reenable macOS 13 tests (flutter/packages#5494) 2023-12-01 mikemcguiness@protonmail.com [flutter_image] Adopt code excerpts in README (flutter/packages#5498) 2023-11-30 kevmoo@users.noreply.github.com [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (flutter/packages#5520) 2023-11-30 stuartmorgan@google.com [google_maps_flutter] Add support for version 8 of the iOS SDK (flutter/packages#5528) 2023-11-30 stuartmorgan@google.com [pointer_interceptor] Re-land: Add platform interface (flutter/packages#5525) 2023-11-30 61667947+T-P-F@users.noreply.github.com [google_sign_in] Add server auth code retrieval to gis_client (flutter/packages#5358) 2023-11-30 engine-flutter-autoroll@skia.org Roll Flutter from 5e5b529 to 918e336 (14 revisions) (flutter/packages#5526) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…er#5528) - Increases the max allowed SDK version to 8.x - Adds a new iOS 14 example app, per [the documented test structure/plan](https://github.com/flutter/packages/blob/main/packages/google_maps_flutter/google_maps_flutter_ios/example/README.md) - Moves recently added XCUITests to the iOS 11 example app, where they should have been (per doc linked above). I missed this when reviewing the addition, and noticed that it was incorrectly in the iOS 13 example while duplicating the iOS 13 example for the iOS 14 version. Fixes flutter/flutter#138972
|
Hey @stuartmorgan in file (packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/README.md) The actual text is: But, the right is: right? |
|
Yes, that's a copy/paste mistake. |
Closed
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…er#5528) - Increases the max allowed SDK version to 8.x - Adds a new iOS 14 example app, per [the documented test structure/plan](https://github.com/flutter/packages/blob/main/packages/google_maps_flutter/google_maps_flutter_ios/example/README.md) - Moves recently added XCUITests to the iOS 11 example app, where they should have been (per doc linked above). I missed this when reviewing the addition, and noticed that it was incorrectly in the iOS 13 example while duplicating the iOS 13 example for the iOS 14 version. Fixes flutter/flutter#138972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#138972
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).