[web_benchmarks] migrate to pkg:web #5592
Conversation
Drop dart:html Enables usage via WebAssembly Fixes flutter/flutter#139577
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
| @@ -20,6 +20,7 @@ dependencies: | |||
| shelf: ^1.2.0 | |||
| shelf_static: ^1.1.0 | |||
| test: ^1.19.5 | |||
| web: '>=0.3.0 <0.5.0' | |||
There was a problem hiding this comment.
So we capture both v0.3.0 and v0.4.0
Because stable pins one version and dev pins the other
There was a problem hiding this comment.
<1.0.0 would also capture 0.4.0, right? And it would also be less sensitive to version constraints in adjacent packages.
There was a problem hiding this comment.
But we're not sure about what we're doing in 0.5.0+ This is a "good" range for things we've tested.
flutter/packages@ca16173...15584a3 2023-12-07 ditman@gmail.com [gis_web] Migrate to package:web. (flutter/packages#5581) 2023-12-07 kevmoo@users.noreply.github.com Drop quiver usage in several packages (flutter/packages#5595) 2023-12-07 stuartmorgan@google.com [video_player] Unfork publish: for macOS (flutter/packages#5578) 2023-12-07 kevmoo@users.noreply.github.com [web_benchmarks] migrate to pkg:web (flutter/packages#5592) 2023-12-07 43054281+camsim99@users.noreply.github.com [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598) 2023-12-06 43054281+camsim99@users.noreply.github.com [animations] Bump minimum Flutter version (flutter/packages#5596) 2023-12-06 6655696+guidezpl@users.noreply.github.com Migrate Material curves to new names (flutter/packages#4898) 2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591) 2023-12-06 louisehsu@google.com [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500) 2023-12-06 stuartmorgan@google.com [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536) 2023-12-06 43759233+kenzieschmoll@users.noreply.github.com Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577) 2023-12-06 stuartmorgan@google.com [google_sign_in] Add macOS support (flutter/packages#4962) 2023-12-06 ian@hixie.ch [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Drop dart:html Enables usage via WebAssembly Fixes flutter/flutter#139577
Drop dart:html Enables usage via WebAssembly Fixes flutter/flutter#139577
Drop dart:html
Enables usage via WebAssembly
Fixes flutter/flutter#139577