Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop quiver usage in several packages #5595

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Drop quiver usage in several packages #5595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b029232
Drop quiver usage in several packages
kevmoo Dec 6, 2023
8db2b31
nit
kevmoo Dec 6, 2023
8fb2265
Merge branch 'main' into drop_quiver
kevmoo Dec 7, 2023
0c13200
Merge branch 'main' into drop_quiver
kevmoo Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT
## 0.10.5+6

* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
* Drop unused dependency on `package:quiver`.

## 0.10.5+5

Expand Down
3 changes: 1 addition & 2 deletions packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
Dart.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.10.5+5
version: 0.10.5+6

environment:
sdk: ">=3.0.0 <4.0.0"
Expand All @@ -28,7 +28,6 @@ dependencies:
flutter:
sdk: flutter
flutter_plugin_android_lifecycle: ^2.0.2
quiver: ^3.0.0

dev_dependencies:
flutter_test:
Expand Down
1 change: 0 additions & 1 deletion packages/camera/camera_android/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ dependencies:
flutter:
sdk: flutter
path_provider: ^2.0.0
quiver: ^3.0.0
video_player: ^2.1.4

dev_dependencies:
Expand Down
1 change: 0 additions & 1 deletion packages/camera/camera_avfoundation/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ dependencies:
flutter:
sdk: flutter
path_provider: ^2.0.0
quiver: ^3.0.0
video_player: ^2.1.4

dev_dependencies:
Expand Down
3 changes: 2 additions & 1 deletion packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT
## 2.4.3

* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
* Drop dependency on `package:quiver`.

## 2.4.2

Expand Down
7 changes: 3 additions & 4 deletions packages/google_sign_in/google_sign_in_platform_interface/lib/src/types.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// found in the LICENSE file.

import 'package:flutter/widgets.dart';
import 'package:quiver/core.dart';

/// Default configuration options to use when signing in.
///
Expand Down Expand Up @@ -132,8 +131,8 @@ class GoogleSignInUserData {
@override
// TODO(stuartmorgan): Make this class immutable in the next breaking change.
// ignore: avoid_equals_and_hash_code_on_mutable_classes
int get hashCode => hashObjects(
<String?>[displayName, email, id, photoUrl, idToken, serverAuthCode]);
int get hashCode =>
Object.hash(displayName, email, id, photoUrl, idToken, serverAuthCode);

@override
// TODO(stuartmorgan): Make this class immutable in the next breaking change.
Expand Down Expand Up @@ -176,7 +175,7 @@ class GoogleSignInTokenData {
@override
// TODO(stuartmorgan): Make this class immutable in the next breaking change.
// ignore: avoid_equals_and_hash_code_on_mutable_classes
int get hashCode => hash3(idToken, accessToken, serverAuthCode);
int get hashCode => Object.hash(idToken, accessToken, serverAuthCode);

@override
// TODO(stuartmorgan): Make this class immutable in the next breaking change.
Expand Down
3 changes: 1 addition & 2 deletions packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/google_sign_i
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
version: 2.4.2
version: 2.4.3

environment:
sdk: ">=3.0.0 <4.0.0"
Expand All @@ -14,7 +14,6 @@ dependencies:
flutter:
sdk: flutter
plugin_platform_interface: ^2.1.0
quiver: ^3.0.0

dev_dependencies:
flutter_test:
Expand Down