Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates #5597

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Dec 7, 2023

Fixes flutter/flutter#133583

This was waiting on the stable release that add keep alive support. Now it is available in the tableView delegates.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Dec 7, 2023
@Piinks Piinks requested a review from goderbauer December 7, 2023 00:50
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
Copy link
Contributor

auto-submit bot commented Dec 7, 2023

auto label is removed for flutter/packages/5597, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
@auto-submit auto-submit bot merged commit 0b78be3 into flutter:main Dec 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 8, 2023
flutter/packages@15584a3...6cd0657

2023-12-08 ditman@gmail.com [gis_web] Correct pub.dev changelog entry. (flutter/packages#5613)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add the ability to run web_benchmarks with Wasm (flutter/packages#5611)
2023-12-08 stuartmorgan@google.com [google_sign_in] Endorse macOS implementation (flutter/packages#5600)
2023-12-07 clairepdavis@gmail.com [go_router_builder] add support to `go_router_builder` for initializing a `ShellRoute` with `observers` (flutter/packages#5563)
2023-12-07 41113988+MarinMikael@users.noreply.github.com [go_router] Fix(docs): Typo in Update navigation.md (flutter/packages#5545)
2023-12-07 katelovett@google.com [two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates (flutter/packages#5597)
2023-12-07 cepadilla@google.com [pigeon] Fix pigeon issue_tracker link (flutter/packages#5505)
2023-12-07 louisehsu@google.com Pointer interceptor implementations (flutter/packages#5594)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
…delegates (flutter#5597)

Fixes flutter/flutter#133583

This was waiting on the stable release that add keep alive support. Now it is available in the tableView delegates.
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…delegates (flutter#5597)

Fixes flutter/flutter#133583

This was waiting on the stable release that add keep alive support. Now it is available in the tableView delegates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose addAutomaticKeepAlives in TableView child delegates
2 participants