Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs for fuchsia_ctl #56

Merged
merged 3 commits into from
Dec 18, 2019
Merged

fix docs for fuchsia_ctl #56

merged 3 commits into from
Dec 18, 2019

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Dec 17, 2019

Add docs, remove analysis_options exception.

@dnfield dnfield requested a review from goderbauer December 17, 2019 23:06
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you please also remove fuchsia_ctl from https://github.com/flutter/packages/blob/master/.cirrus.yml#L15? Thanks!

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dnfield dnfield merged commit 9cbecee into flutter:master Dec 18, 2019
stuartmorgan pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants