Skip to content

Conversation

@ma-pe
Copy link

@ma-pe ma-pe commented Jan 8, 2024

I added a hint to the readme, that iOS apps need to have a minimum deployment target >= 14.0 to use cloud-based map styling. This is necessary because the feature was introduced with GoogleMaps SDK 8.3.0 which is not available for iOS < 14.0.

Relevant part of GoogleMaps iOS SDK Changelog

There is no Github Issue but a StackOverflow Question that I answered.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Cloud based map styling requires a GoogleMaps iOS SDK >= 8.3.0, which itself supports iOS deployment targets from 14.0.
@stuartmorgan-g
Copy link
Collaborator

This is necessary because the feature was introduced with GoogleMaps SDK 8.3.0

According to the official documentation, cloud-based styling is available in 5.x. Is the assertion here that legacy styling does not in fact work in the plugin on iOS 11? If so, please file an issue with detailed steps to reproduce.

In the future, please don't just check all the checkboxes without actually doing the steps. The checklist is there as a guide to complete steps that are required for PRs.

@ma-pe
Copy link
Author

ma-pe commented Jan 17, 2024

In the future, please don't just check all the checkboxes without actually doing the steps. The checklist is there as a guide to complete steps that are required for PRs.

Aye! I'll leave them unchecked next time.

According to the official documentation, cloud-based styling is available in 5.x.

Oh, you are right! I missed that.

Is the assertion here that legacy styling does not in fact work in the plugin on iOS 11? If so, please file an issue with detailed steps to reproduce.

I was expecting this to be the case. Yet when trying to reproduce this in a fresh Flutter app, all worked fine (I double checked, that Google Maps sdk 5.X is used). So it seems to be related to other things going on in my repo.

I will therefore close this PR, sorry and thank you for taking a look! ✌️

@ma-pe ma-pe closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants