Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Updates the repo tooling to Dart 3, now that the N-2 version has Dart 3, which allows us to use Dart 3 features (e.g., records) going forward.

To allow the update:

  • Removes break commands from switches (all done automatically with dart fix --apply)
  • Replaces mocking of ProcessResult with just creating an actual ProcessResult since it's a final data class and thus can't (but also doesn't need to be) mocked.

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more breaks

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2024
@auto-submit auto-submit bot merged commit 7403992 into flutter:main Feb 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 7, 2024
flutter/packages@1a5a7ce...e4ea6bf

2024-02-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 0b5cd50 to e6ba809 (12 revisions) (flutter/packages#6066)
2024-02-06 stuartmorgan@google.com [tool] Update to Dart 3 (flutter/packages#6030)
2024-02-06 stuartmorgan@google.com [ci] Move tool_runner.sh (flutter/packages#6038)
2024-02-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/packages#6063)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants