[go_router] Documentation for StatefulShellRoute #6308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@johnpryan could you have a look at this? |
chunhtai
reviewed
Apr 8, 2024
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
Thanks for adding the document. Since we start to use code-excerpt, can you try to follow this when adding the example code in doc? https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#add-or-converting-a-code-block
| which is passed as the last argument to the builder function. Example: | ||
|
|
||
| ```dart | ||
| StatefulShellRoute.indexedStack( |
Contributor
There was a problem hiding this comment.
We have example that may be easier to follow https://github.com/flutter/packages/blob/main/packages/go_router/example/lib/others/custom_stateful_shell_route.dart
Contributor
|
Hi @tolo are you still working on this pr? |
Contributor
Author
Yes, I'll have a look at code-excerpt and update the code / docs. |
Contributor
|
closing this pr for now, feel free to reopen when you have time |
Contributor
Author
|
@chunhtai I pushed new commits over a month ago which I don’t think you have reviewed yet (didn’t request a new review though, sorry). |
hannah-hyj
approved these changes
Jul 24, 2024
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 2, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 rexios@rexios.dev [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 ditman@gmail.com [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 ditman@gmail.com [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 tobias@leafnode.se [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 stuartmorgan@google.com [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 stuartmorgan@google.com [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 tarrinneal@gmail.com [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 rexios@rexios.dev [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 ditman@gmail.com [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 ditman@gmail.com [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 tobias@leafnode.se [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 stuartmorgan@google.com [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 stuartmorgan@google.com [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 tarrinneal@gmail.com [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 rexios@rexios.dev [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 ditman@gmail.com [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 ditman@gmail.com [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 tobias@leafnode.se [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 stuartmorgan@google.com [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 stuartmorgan@google.com [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 tarrinneal@gmail.com [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation about StatefulShellRoute to the Configuration topic (configuration.md).
Fixes flutter/flutter#127209.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.