Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] Kotlin implementation for ProxyApis #6371

Merged
merged 115 commits into from
Aug 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
115 commits
Select commit Hold shift + click to select a range
7d66bf7
add other stuff
bparrishMines Mar 21, 2024
d64d2a2
add partial generator code
bparrishMines Mar 21, 2024
b64d723
add generated file
bparrishMines Mar 21, 2024
89d3c92
finish additions
bparrishMines Mar 21, 2024
1f7d0ad
some fixes
bparrishMines Mar 21, 2024
fa3c943
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Apr 10, 2024
2665c22
add onWriteBody
bparrishMines Apr 11, 2024
cadf14c
use a common method for api math
bparrishMines Apr 15, 2024
2bf6738
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Apr 15, 2024
6437fc9
add all stuff back
bparrishMines Apr 15, 2024
aea71cd
changelogg
bparrishMines Apr 15, 2024
0c09e91
formatting
bparrishMines Apr 16, 2024
f114c8c
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Apr 16, 2024
d57ac0d
fix proxy api separated suffix
bparrishMines Apr 16, 2024
ff1e210
switch to a registrar
bparrishMines Apr 16, 2024
7e345ac
docs
bparrishMines Apr 16, 2024
db2a198
formatting
bparrishMines Apr 16, 2024
a7c94e5
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Apr 16, 2024
7af4343
fix unit tests
bparrishMines Apr 16, 2024
a7b20a0
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Apr 16, 2024
f2a1d5b
improve helper method and add test
bparrishMines Apr 17, 2024
f76265e
add a setter for clearFinalizedWeakReferencesInterval
bparrishMines Apr 17, 2024
b8e70f6
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Apr 17, 2024
4f2327d
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Apr 24, 2024
5ade010
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines May 7, 2024
3b3a91b
return empty list in removeStrongReference
bparrishMines May 7, 2024
ec37d62
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines May 9, 2024
186fe47
update generated file
bparrishMines May 9, 2024
894e642
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines May 15, 2024
118606a
make private codec accessible and use open for pigeonRegistrar
bparrishMines May 20, 2024
4e821cb
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines May 20, 2024
4205418
nits
bparrishMines May 20, 2024
258653b
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines May 24, 2024
5070f6e
shared channel code for instancemanagerapi
bparrishMines May 29, 2024
06d163b
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines May 29, 2024
79e994b
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines May 30, 2024
1b9dfc1
make fullclassname nullable
bparrishMines May 30, 2024
f91a51f
use name constants and add a computation to the proxy api
bparrishMines May 30, 2024
84e0a0c
fix unit tests
bparrishMines May 30, 2024
bdf1aae
test api registrar
bparrishMines May 30, 2024
2ff9075
support a default api implementation
bparrishMines May 30, 2024
b0569f5
update instancemanager docs
bparrishMines Jun 3, 2024
4f47756
stops
bparrishMines Jun 3, 2024
03d1100
switch to format
bparrishMines Jun 4, 2024
c49aff2
regen and no ps
bparrishMines Jun 4, 2024
c7e5ad0
use addDocumenetationCommetns instead
bparrishMines Jun 4, 2024
d1883be
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jun 4, 2024
3025438
use write scoped
bparrishMines Jun 4, 2024
9af2d08
use indentscoped
bparrishMines Jun 4, 2024
78128b8
use format
bparrishMines Jun 4, 2024
84879d2
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jun 4, 2024
90f38b6
fix api check probably
bparrishMines Jun 4, 2024
505b500
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jun 11, 2024
172ef36
update codecs to be compatible
bparrishMines Jun 11, 2024
c294d49
analyze error fix
bparrishMines Jun 12, 2024
eaf1302
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jun 12, 2024
03f8a9e
dont use raw when passing enums and test parent codec
bparrishMines Jun 12, 2024
6a57229
formatting
bparrishMines Jun 12, 2024
38ab4a1
verify api requirements work
bparrishMines Jun 17, 2024
78ade11
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jun 17, 2024
fcb3aa5
use helper method
bparrishMines Jun 21, 2024
61579bc
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jun 28, 2024
c981d97
update format trim indentation
bparrishMines Jul 12, 2024
60be3da
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jul 12, 2024
0b7de44
also check nullable can return nonnull
bparrishMines Jul 12, 2024
8974f28
update to use file specific prefixes
bparrishMines Jul 16, 2024
4ae228d
fix test
bparrishMines Jul 16, 2024
e5ad0ce
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jul 16, 2024
77ac326
logging has name limits
bparrishMines Jul 16, 2024
33e3742
add file prefix
bparrishMines Jul 16, 2024
927aeea
test fix hopefullY
bparrishMines Jul 16, 2024
ce65169
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jul 17, 2024
1dd1eda
gen without formatting
bparrishMines Jul 19, 2024
bd08aa0
same code no gens
bparrishMines Jul 19, 2024
b2ae858
formatting
bparrishMines Jul 19, 2024
b2b82f6
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jul 19, 2024
4627f4a
formatting
bparrishMines Jul 19, 2024
abe2c0d
check supported types first
bparrishMines Jul 29, 2024
92a7370
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jul 29, 2024
6d5b581
maybe fix kotlin
bparrishMines Jul 29, 2024
770b24c
M`erge branch 'main' of github.com:flutter/packages into pigeon_kotli…
bparrishMines Jul 29, 2024
9e59393
add ignoreCallsToDart
bparrishMines Jul 31, 2024
bc60c15
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Jul 31, 2024
cb10073
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 9, 2024
3b3284a
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 15, 2024
cae65e8
fix kotlin tests and add kotlin prefixes
bparrishMines Aug 15, 2024
82f0cee
fix tools version
bparrishMines Aug 15, 2024
233acf5
fix lint
bparrishMines Aug 15, 2024
e810a8f
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 15, 2024
b95997e
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 16, 2024
24daaa1
try fix instance manager api name
bparrishMines Aug 17, 2024
f0aa519
fix tests
bparrishMines Aug 17, 2024
fed5b58
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 17, 2024
ccb1783
fix unit tests
bparrishMines Aug 17, 2024
0a2a643
fix log name
bparrishMines Aug 17, 2024
942918b
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 23, 2024
89abc69
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 26, 2024
cc55be5
regen code
bparrishMines Aug 26, 2024
41fca50
try lowering version
bparrishMines Aug 26, 2024
78e1e48
fix codec name in instancemanagerapi
bparrishMines Aug 27, 2024
e844875
fix kotlin api too
bparrishMines Aug 27, 2024
af2965f
regen
bparrishMines Aug 27, 2024
25d4515
raise version again
bparrishMines Aug 27, 2024
c5a083e
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 27, 2024
676eb05
some docs
bparrishMines Aug 27, 2024
f7b662a
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 29, 2024
d79c8f0
review comments
bparrishMines Aug 29, 2024
f4ac560
fix other comments locations
bparrishMines Aug 29, 2024
f70c2f1
include gen file actually
bparrishMines Aug 29, 2024
c1f23ae
analyze error
bparrishMines Aug 29, 2024
b958879
codec is not private since it is used in registrar
bparrishMines Aug 29, 2024
ecf079c
Merge branch 'main' of github.com:flutter/packages into pigeon_kotlin…
bparrishMines Aug 29, 2024
98d088f
fix unit test
bparrishMines Aug 29, 2024
923e21e
use messagecodec instead
bparrishMines Aug 29, 2024
f9d5b78
version bump
bparrishMines Aug 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
bparrishMines committed Apr 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit db2a198f4236b23a43327ca1f13ee14aa400684f
Original file line number Diff line number Diff line change
@@ -352,8 +352,8 @@ private class PigeonInstanceManagerApi(val binaryMessenger: BinaryMessenger) {
}

/**
* Provides implementations for each ProxyApi implementation and provides access to resources
* needed by any implementation.
* Provides implementations for each ProxyApi implementation and provides access to resources needed
* by any implementation.
*/
abstract class PigeonProxyApiRegistrar(val binaryMessenger: BinaryMessenger) {
val instanceManager: PigeonInstanceManager