[tool] Check for test and flutter_test in non-dev dependencies
#6472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_test_dependencies_check
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
11 tasks
stuartmorgan-g
requested changes
Apr 8, 2024
| ${_dependenciesSection(<String>['integration_test: \n sdk: flutter'])} | ||
| ${_dependenciesSection(<String>[ | ||
| 'integration_test: \n sdk: flutter', | ||
| 'flutter_test: \n sdk: flutter', |
Collaborator
There was a problem hiding this comment.
If the existing tests are going to change to test more things, then the test descriptions need to change accordingly.
Contributor
Author
There was a problem hiding this comment.
updated test name to 'fails when integration_test, flutter_test or test are used in non dev dependency'
packages/css_colors/CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## NEXT | |||
Collaborator
There was a problem hiding this comment.
This needs a version change, which is why CI is failing.
packages/css_colors/pubspec.yaml
Outdated
| repository: https://github.com/flutter/packages/tree/main/packages/css_colors | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+css_colors%22 | ||
| version: 1.1.4 | ||
| version: 1.1.4+1 |
Collaborator
There was a problem hiding this comment.
Please see the end of https://dart.dev/tools/pub/versioning#semantic-versions. We follow the advice there about when to use (and not use) + in versions.
packages/web_benchmarks/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 1.2.1+1 | |||
…al_test_dependencies_check
stuartmorgan-g
changed the title
test and flutter_test in non-dev dependencies
stuartmorgan-g
changed the title
test and flutter_test in non-dev dependenciestest and flutter_test in non-dev dependencies
Collaborator
|
@bparrishMines or @tarrinneal could you do the secondary review here? |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 11, 2024
flutter/packages@2c15d86...e98839a 2024-04-10 ekuleshov@gmail.com [tool] Check for `test` and `flutter_test` in non-dev dependencies (flutter/packages#6472) 2024-04-10 43054281+camsim99@users.noreply.github.com [camerax] Shorten interval for releasing weak references to Dart-wrapped native objects (flutter/packages#6493) 2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter from 4967a94 to 97cd47a (11 revisions) (flutter/packages#6497) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@2c15d86...e98839a 2024-04-10 ekuleshov@gmail.com [tool] Check for `test` and `flutter_test` in non-dev dependencies (flutter/packages#6472) 2024-04-10 43054281+camsim99@users.noreply.github.com [camerax] Shorten interval for releasing weak references to Dart-wrapped native objects (flutter/packages#6493) 2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter from 4967a94 to 97cd47a (11 revisions) (flutter/packages#6497) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…lutter#6472) *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* Additional checks as a followup to flutter#6446 *List which issues are fixed by this PR. You must list at least one issue.* Related to flutter/flutter#145992 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
Additional checks as a followup to #6446
List which issues are fixed by this PR. You must list at least one issue.
Related to flutter/flutter#145992
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.