[camera_android] Remove TestUtils.java
#6490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from cameratest.java
matanlurey
approved these changes
Apr 8, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Looks... better :)
We should chat in person sometime about what the testing strategy here is, like it's not common for me to see so many internal-state fields changed/probed during tests, but I also might be missing some bigger picture.
LGTM!
Member
Author
I agree, but I think fixing the testing strategy for the It is hard to justify spending much effort on it, when that effort could instead be spent improving the new CameraX implementation that we would ideally get everyone to switch to. Happy to talk about it either way though |
Contributor
|
Yeah, maybe the take away will just be "what not to do in |
added 2 commits
April 8, 2024 15:59
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 9, 2024
flutter/packages@6b4d8b6...17f55d3 2024-04-09 barpac02@gmail.com Release compileSdk changes (flutter/packages#6491) 2024-04-08 34871572+gmackall@users.noreply.github.com [camera_android] Remove `TestUtils.java` (flutter/packages#6490) 2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter from 98d23f7 to 533d04d (12 revisions) (flutter/packages#6488) 2024-04-08 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Add `restorationScopeId` to `ShellRouteData` (flutter/packages#6238) 2024-04-08 39844581+kforjan@users.noreply.github.com [go_router] Fixes deep links with no path (flutter/packages#6447) 2024-04-08 stuartmorgan@google.com [in_app_purchase] Convert Android data objects to Pigeon (flutter/packages#6453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@6b4d8b6...17f55d3 2024-04-09 barpac02@gmail.com Release compileSdk changes (flutter/packages#6491) 2024-04-08 34871572+gmackall@users.noreply.github.com [camera_android] Remove `TestUtils.java` (flutter/packages#6490) 2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter from 98d23f7 to 533d04d (12 revisions) (flutter/packages#6488) 2024-04-08 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Add `restorationScopeId` to `ShellRouteData` (flutter/packages#6238) 2024-04-08 39844581+kforjan@users.noreply.github.com [go_router] Fixes deep links with no path (flutter/packages#6447) 2024-04-08 stuartmorgan@google.com [in_app_purchase] Convert Android data objects to Pigeon (flutter/packages#6453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Removes `TestUtils.java`, in favor of using `@VisibileForTesting` instead. I had to change a couple of types from the interface type to the actual implementation type too, to accomplish the removal. fixes flutter/flutter#146457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
TestUtils.java, in favor of using@VisibileForTestinginstead. I had to change a couple of types from the interface type to the actual implementation type too, to accomplish the removal.fixes flutter/flutter#146457
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.