[Android][webview_flutter] Run integration tests on emulators running Android 34 #6499

camsim99 · 2024-04-10T17:31:14Z

Changes webview_flutter , webview_flutter_android tests to run on emulators running SDK 34 for Android. I also

Changed all unawaited calls in non-legacy tests to await. I believe several of the setup steps need to be completed before running checks based on testing, so this should leave the tests safer overall.
Changing the integration test directory structures look like what is described in the integration_test packages instructions. Without changing the package to this structure, CI seemed to run the tests in parallel. I am still trying to figure out why this is but no longer want to block this PR.

Also removes shards for testing packages against Android 33 since no packages are running on emulators running Android 33 anymore.

Fixes flutter/flutter#140001. Fixes flutter/flutter#137083.

Pre-launch Checklist

This reverts commit 9900937.

This reverts commit 8d6b444.

camsim99 · 2024-04-17T21:08:31Z

Wait the test just failed 😅 it might be flaky. Let me test something.

Edit: It is confirmed flaky. I would say this PR still helps though because before it would consistently fail. I need to try to identify the flaky call.

…f_34_await

…android webview

camsim99 · 2024-04-30T16:24:33Z

@reidbaker as per your request, I took a look at the webview test runs on emulators running API 33 to see if this change causes it to be any more flaky than it was, and the answer is I don't know -- I looked through the past 200 runs of the relevant target and none of them actually get to the point of running the test that is flaky here.

Unless it starts blocking the tree (which I don't think it will based on how rarely this test runs), I would like to merge this and follow up on any flakiness from this test as it would almost certainly involve digging into how this plugin works, but let me know what you think.

reidbaker · 2024-04-30T16:28:06Z

That sounds reasonable to me and thank you for checking

… running Android 34 (flutter/packages#6499)

flutter/packages@6c4482a...1412041 2024-05-13 stuartmorgan@google.com [in_app_purchase] Update country code Android example (flutter/packages#6722) 2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter from 1dfb46e to 1255435 (6 revisions) (flutter/packages#6723) 2024-05-13 43054281+camsim99@users.noreply.github.com [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629) 2024-05-13 15619084+vashworth@users.noreply.github.com [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707) 2024-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 2aa05c1 to 1dfb46e (3 revisions) (flutter/packages#6715) 2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter/packages#6713) 2024-05-10 stuartmorgan@google.com [quick_actions] Add Swift Package Manager support (flutter/packages#6682) 2024-05-10 stuartmorgan@google.com [url_launcher] Add Swift Package Manager support (flutter/packages#6677) 2024-05-10 43054281+camsim99@users.noreply.github.com [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499) 2024-05-10 50643541+Mairramer@users.noreply.github.com [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691) 2024-05-10 43054281+camsim99@users.noreply.github.com [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697) 2024-05-10 737941+loic-sharma@users.noreply.github.com Update .gitignore for Swift Package Manager (flutter/packages#6705) 2024-05-10 34871572+gmackall@users.noreply.github.com [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638) 2024-05-10 737941+loic-sharma@users.noreply.github.com [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708) 2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter from 00f4066 to 2bfb1b0 (9 revisions) (flutter/packages#6706) 2024-05-09 38299943+VictorOhashi@users.noreply.github.com [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… Android 34 (flutter#6499) Changes webview_flutter , webview_flutter_android tests to run on emulators running SDK 34 for Android. I also 1. Changed all `unawaited` calls in non-legacy tests to `await`. I believe several of the setup steps need to be completed before running checks based on testing, so this should leave the tests safer overall. 2. Changing the integration test directory structures look like what is described in [the integration_test packages instructions](https://github.com/flutter/flutter/blob/master/packages/integration_test/README.md#package-structure). Without changing the package to this structure, CI seemed to run the tests in parallel. I am still trying to figure out why this is but no longer want to block this PR. Also removes shards for testing packages against Android 33 since no packages are running on emulators running Android 33 anymore. Fixes flutter/flutter#140001. Fixes flutter/flutter#137083.

Changes for test

8318874

github-actions bot added the p: webview_flutter label Apr 10, 2024

camsim99 mentioned this pull request Apr 10, 2024

[webview_flutter_android] Run tests on API 34 emulators #6339

Closed

11 tasks

camsim99 and others added 8 commits April 10, 2024 10:32

Run on 34

a8fc572

Remove 33 only tests, testing verbose change

0d52ab9

Move test

e1641eb

Try just moving legacy

9900937

Revert "Try just moving legacy"

25742fb

This reverts commit 9900937.

Try moving test back to double check

8d6b444

Revert "Try moving test back to double check"

93c4a5d

This reverts commit 8d6b444.

Merge branch 'main' into wf_34_await

3a22243

camsim99 changed the title ~~[webview_flutter_android] Run integration tests on emulators running Android 34~~ [Android][webview_flutter] Run integration tests on emulators running Android 34 Apr 17, 2024

camsim99 marked this pull request as ready for review April 17, 2024 20:44

camsim99 requested a review from bparrishMines as a code owner April 17, 2024 20:44

camsim99 requested a review from stuartmorgan April 17, 2024 20:47

camsim99 marked this pull request as draft April 17, 2024 21:08

camsim99 added 5 commits April 18, 2024 12:55

Try common await change

72cccfa

Merge remote-tracking branch 'refs/remotes/origin/wf_34_await' into w…

e135fbb

…f_34_await

Get rid of unawaiteds

1a20934

Add print statements to debug in CI + add pump and settle call

7e82e47

Remove unawaiteds + move legacy test outside of its own directory in …

47e093f

…android webview

github-actions bot added the platform-android label Apr 23, 2024

camsim99 added 6 commits April 23, 2024 12:00

Add missing pumpAndSettle

fe19f00

Dart fixes

98a175b

Remove print statements

e1edba5

Fix analyzer

2645d8b

Merge remote-tracking branch 'upstream/main' into wf_34_await

43ab76d

Nits

9a903d5

camsim99 marked this pull request as ready for review April 30, 2024 16:19

reidbaker approved these changes May 9, 2024

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024

auto-submit bot merged commit a489d49 into flutter:main May 10, 2024
75 checks passed

engine-flutter-autoroll mentioned this pull request May 13, 2024

Roll Packages from 6c4482a64492 to ee8ee2eaa23e (13 revisions) flutter/flutter#148217

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024

a489d49 [Android][webview_flutter] Run integration tests on emulators…

c864210

… running Android 34 (flutter/packages#6499)

engine-flutter-autoroll mentioned this pull request May 13, 2024

Roll Packages from 6c4482a64492 to 9588cce77dba (14 revisions) flutter/flutter#148223

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024

a489d49 [Android][webview_flutter] Run integration tests on emulators…

87afb58

… running Android 34 (flutter/packages#6499)

engine-flutter-autoroll mentioned this pull request May 13, 2024

Roll Packages from 6c4482a64492 to f91f68916da9 (15 revisions) flutter/flutter#148232

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024

a489d49 [Android][webview_flutter] Run integration tests on emulators…

c9df9a4

… running Android 34 (flutter/packages#6499)

engine-flutter-autoroll mentioned this pull request May 13, 2024

Roll Packages from 6c4482a64492 to 1412041fa3fe (16 revisions) flutter/flutter#148239

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024

a489d49 [Android][webview_flutter] Run integration tests on emulators…

16d4c21

… running Android 34 (flutter/packages#6499)

reidbaker mentioned this pull request Jul 2, 2024

i151188 update espresso dependencies v2 reidbaker/packages#6

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android][webview_flutter] Run integration tests on emulators running Android 34 #6499

[Android][webview_flutter] Run integration tests on emulators running Android 34 #6499

camsim99 commented Apr 10, 2024 •

edited

Loading

camsim99 commented Apr 17, 2024 •

edited

Loading

camsim99 commented Apr 30, 2024

reidbaker commented Apr 30, 2024

[Android][webview_flutter] Run integration tests on emulators running Android 34 #6499

[Android][webview_flutter] Run integration tests on emulators running Android 34 #6499

Conversation

camsim99 commented Apr 10, 2024 • edited Loading

Pre-launch Checklist

camsim99 commented Apr 17, 2024 • edited Loading

camsim99 commented Apr 30, 2024

reidbaker commented Apr 30, 2024

camsim99 commented Apr 10, 2024 •

edited

Loading

camsim99 commented Apr 17, 2024 •

edited

Loading