-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CupertinoIcons] fix broken icons and vertical alignment, bump the version to 1.08 #6520
Merged
auto-submit
merged 2 commits into
flutter:main
from
LongCatIsLooong:cupertino-icon-fixes
Apr 16, 2024
Merged
[CupertinoIcons] fix broken icons and vertical alignment, bump the version to 1.08 #6520
auto-submit
merged 2 commits into
flutter:main
from
LongCatIsLooong:cupertino-icon-fixes
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGoodwin
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LongCatIsLooong
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Apr 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2024
…p the version to 1.08 (flutter/packages#6520)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2024
…p the version to 1.08 (flutter/packages#6520)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 16, 2024
flutter/packages@6698b2d...90c876d 2024-04-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/packages#6545) 2024-04-16 31859944+LongCatIsLooong@users.noreply.github.com [CupertinoIcons] fix broken icons and vertical alignment, bump the version to 1.08 (flutter/packages#6520) 2024-04-16 26625149+0xZOne@users.noreply.github.com [video_player] Calls `onDestroy` instead of `initialize` in onDetachedFromEngine (flutter/packages#6501) 2024-04-15 mikemcguiness@protonmail.com [image_picker] Adopt code excerpts in README (flutter/packages#5523) 2024-04-15 mdebbar@google.com [url_launcher][web] Link should work when triggered by keyboard (flutter/packages#6505) 2024-04-15 engine-flutter-autoroll@skia.org Manual roll Flutter from 53cba24 to 2e748e8 (19 revisions) (flutter/packages#6541) 2024-04-15 stuartmorgan@google.com Update local_auth_android minSdkVersion to 19 (flutter/packages#6537) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@6698b2d...90c876d 2024-04-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/packages#6545) 2024-04-16 31859944+LongCatIsLooong@users.noreply.github.com [CupertinoIcons] fix broken icons and vertical alignment, bump the version to 1.08 (flutter/packages#6520) 2024-04-16 26625149+0xZOne@users.noreply.github.com [video_player] Calls `onDestroy` instead of `initialize` in onDetachedFromEngine (flutter/packages#6501) 2024-04-15 mikemcguiness@protonmail.com [image_picker] Adopt code excerpts in README (flutter/packages#5523) 2024-04-15 mdebbar@google.com [url_launcher][web] Link should work when triggered by keyboard (flutter/packages#6505) 2024-04-15 engine-flutter-autoroll@skia.org Manual roll Flutter from 53cba24 to 2e748e8 (19 revisions) (flutter/packages#6541) 2024-04-15 stuartmorgan@google.com Update local_auth_android minSdkVersion to 19 (flutter/packages#6537) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…rsion to 1.08 (flutter#6520) See this PR for the font change: xster/framework7-icons#2
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…rsion to 1.08 (flutter#6520) See this PR for the font change: xster/framework7-icons#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this PR for the font change: xster/framework7-icons#2
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.