[image_picker] Adds comment for the limit parameter #6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
reviewed
May 7, 2024
| @@ -112,6 +112,12 @@ class ImagePicker { | |||
| /// image types such as JPEG and on Android PNG and WebP, too. If compression is not | |||
| /// supported for the image that is picked, a warning message will be logged. | |||
| /// | |||
| /// The `limit` parameter modifies the maximum number of images that can be selected. | |||
| /// On Android, you need to set ImagePickerAndroid's useAndroidPhotoPicker to | |||
There was a problem hiding this comment.
There should be [] around ImagePickerAndroid, and `` around useAndroidPhotoPicker
This also seems a little verbose, maybe shorten it to
On Android, [ImagePickerAndroid.useAndroidPhotoPicker] must be set to `true` to use the `limit` functionality
I'm not sure the see: [link] part is necessary either.
Same for the other instance of this comment.
There was a problem hiding this comment.
Thanks for the review, I've readjusted it.
|
I guess, before this gets merged, is this a feature that isn't available in the android sdk? or is it just not implemented properly in the plugin? |
|
I made a reply here(flutter/flutter#147773 (comment)) and adjusted the comment. Please review again. |
stuartmorgan
reviewed
May 8, 2024
LinXunFeng
force-pushed
the
image_picker_comment
branch
2 times, most recently
from
7f80eaf to
5b0a880
Compare
|
It looks like there are some comments here otherwise the PR looks good. Do you plan to update this pr? if not we understand and thank you for the effort you have already spent. |
reidbaker
approved these changes
May 30, 2024
LinXunFeng
force-pushed
the
image_picker_comment
branch
from
5b0a880 to
174414f
Compare
|
@reidbaker, thanks for your review. I have previously moved the comments about the Android part to the README of Now I have rebased the latest code and resolved the conflict. |
stuartmorgan
approved these changes
May 31, 2024
reidbaker
approved these changes
May 31, 2024
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2024
flutter/packages@910fabb...d8e8e8c 2024-05-31 linxunfeng@yeah.net [image_picker] Adds comment for the limit parameter (flutter/packages#6678) 2024-05-30 jonahwilliams@google.com Revert "Migrate CameraX from SurfaceTexture to SurfaceProducer." (flutter/packages#6838) 2024-05-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Updates `PigeonInstanceMangerApi` to use the shared api channel code in Dart (flutter/packages#6831) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
flutter/packages@910fabb...d8e8e8c 2024-05-31 linxunfeng@yeah.net [image_picker] Adds comment for the limit parameter (flutter/packages#6678) 2024-05-30 jonahwilliams@google.com Revert "Migrate CameraX from SurfaceTexture to SurfaceProducer." (flutter/packages#6838) 2024-05-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Updates `PigeonInstanceMangerApi` to use the shared api channel code in Dart (flutter/packages#6831) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#147773
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.