[flutter_markdown] fixes null check operator used on null value if onSelectionChanged is… #6883
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
As advised by navaronbracke at Discord I'll add a widget test for this and resubmit |
| @@ -156,198 +160,198 @@ | |||
|
|
|||
| ## 0.6.10 | |||
|
|
|||
| * Update `markdown` dependency | |||
There was a problem hiding this comment.
Can you revert the format change? It makes this PR noisy?
There was a problem hiding this comment.
@domesticmouse I had noticed the reformat had accidentally slipped through and I was going to revert it when I added the test however I realised it had only reformatted the second half of the file (0.6.10 and earlier) as the first half of the changelog was already formatted according to best practices. So it made the changelogs second half consistent with the first which I thought maybe wasn't a bad thing?
Happy to revert it though if you think keeping the pr tidy is better? Let me know and I'll update it the same day. Thanks
There was a problem hiding this comment.
I'll defer to @stuartmorgan on this one
There was a problem hiding this comment.
Changing to our standard format is a positive, so this can stay; we sometimes have changes like this where editors trim trailing whitespace off of old entries as well, and land those.
It's just purely churn changes (like editors that change all *s to -s) that I ask people to revert.
|
Also, please fix conflicts. Thanks! |
| @@ -156,198 +160,198 @@ | |||
|
|
|||
| ## 0.6.10 | |||
|
|
|||
| * Update `markdown` dependency | |||
There was a problem hiding this comment.
Changing to our standard format is a positive, so this can stay; we sometimes have changes like this where editors trim trailing whitespace off of old entries as well, and land those.
It's just purely churn changes (like editors that change all *s to -s) that I ask people to revert.
|
Thanks for the feedback @stuartmorgan and @domesticmouse -I appreciate your time. This should be good to go now but let me know if there's anything else. |
stuartmorgan
added
the
autosubmit
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
…ue if onSelectionChanged is… (flutter/packages#6883)
flutter/packages@711b4ac...03f5f6d 2024-06-24 stuartmorgan@google.com [interactive_media_ads] Fix README badge image URL (flutter/packages#6979) 2024-06-24 36191829+biagiopietro@users.noreply.github.com [multicast_dns] Optimized Socket Binding: Always bind to 0.0.0.0 for simplicity and efficiency - #79772 (flutter/packages#6700) 2024-06-24 92950982+oravecz-jpmc@users.noreply.github.com [flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() (flutter/packages#6510) 2024-06-22 louisehsu@google.com [in_app_purchase_storekit] Remove OCMock (flutter/packages#6862) 2024-06-22 stuartmorgan@google.com [google_maps_flutter] Add iOS SDK 9.x support (flutter/packages#6902) 2024-06-21 stuartmorgan@google.com [google_maps_flutter] Partial Android host API Pigeon conversion (flutter/packages#6967) 2024-06-21 github@alexv525.com Revert "Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`." (flutter/packages#6964) 2024-06-21 stuartmorgan@google.com [quick_actions] Update to Pigeon 20 (flutter/packages#6961) 2024-06-20 stuartmorgan@google.com [google_maps_flutter] Move Android inspector to Pigeon (flutter/packages#6958) 2024-06-20 engine-flutter-autoroll@skia.org Manual roll Flutter from ccf3abe to 6c06abb (21 revisions) (flutter/packages#6954) 2024-06-20 34871572+gmackall@users.noreply.github.com [many] More v1 embedding deletion that was missed in flutter/packages#6494 (flutter/packages#6923) 2024-06-20 joonas.kerttula@codemate.com [google_maps_flutter] deprecate old BitmapDescriptor methods (flutter/packages#6905) 2024-06-18 magder@google.com [pigeon] Fully-qualify types in Equatable extension test (flutter/packages#6946) 2024-06-18 jimmyxx@gmail.com [flutter_markdown] fixes null check operator used on null value if onSelectionChanged is� (flutter/packages#6883) 2024-06-17 engine-flutter-autoroll@skia.org Roll Flutter from 5187cab to ccf3abe (6 revisions) (flutter/packages#6940) 2024-06-17 50375243+Jerinji2016@users.noreply.github.com [google_sign_in_web] README.md typo (flutter/packages#6642) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.1-android to 33.2.1-android and CameraX version to 1.3.4 in /packages/camera/camera_android_camerax/android (flutter/packages#6847) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.1-android to 33.2.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#6846) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [quick_actions]: Bump com.android.tools.build:gradle from 7.2.1 to 8.4.1 in /packages/quick_actions/quick_actions_android/android (flutter/packages#6799) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/path_provider/path_provider_android/android (flutter/packages#6773) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/camera/camera_android/android (flutter/packages#6766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
[flutter_markdown] fixes null check operator used on null value if onSelectionChanged is… (flutter#6883) - Fixes flutter/flutter/issues/149817 - Fixes flutter/flutter/issues/146282
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).