-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Adds @matanlurey to some Android CODEOWNERS until Impeller is enabled. #7014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Jun 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ditman
changed the title
Have @matanlurey "watch" the Android plugins for changes until Impeller is enabled
[ci] Adds @matanlurey to some Android CODEOWNERS until Impeller is enabled.
Jun 29, 2024
camsim99
approved these changes
Jul 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 2, 2024
flutter/packages@412ec46...d2705fb 2024-07-01 engine-flutter-autoroll@skia.org Roll Flutter from 651a17d to 99bb2ff (10 revisions) (flutter/packages#7038) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7032) 2024-07-01 stuartmorgan@google.com [google_maps_flutter] Semi-convert remaining Android host API calls to Pigeon (flutter/packages#6980) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/local_auth/local_auth_android/android (flutter/packages#7022) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.0 in /packages/video_player/video_player_android/android (flutter/packages#6931) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.0 in /packages/camera/camera_android/android (flutter/packages#6928) 2024-07-01 matanlurey@users.noreply.github.com [ci] Adds @matanlurey to some Android CODEOWNERS until Impeller is enabled. (flutter/packages#7014) 2024-06-29 ditman@gmail.com [video_player] Bumps web implementation dependency. (flutter/packages#7015) 2024-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 15f95ce to 651a17d (7 revisions) (flutter/packages#7013) 2024-06-28 36687028+phong010198@users.noreply.github.com [flutter_markdown] Add horizontal scroll for markdown table (flutter/packages#6983) 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/packages#6709) 2024-06-28 stuartmorgan@google.com [google_maps_flutter] Fix Obj-C type handling (flutter/packages#7010) 2024-06-28 engine-flutter-autoroll@skia.org Manual roll Flutter from e726eb4 to 15f95ce (48 revisions) (flutter/packages#7002) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
TahaTesser
pushed a commit
to TahaTesser/flutter
that referenced
this pull request
Jul 8, 2024
flutter/packages@412ec46...d2705fb 2024-07-01 engine-flutter-autoroll@skia.org Roll Flutter from 651a17d to 99bb2ff (10 revisions) (flutter/packages#7038) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7032) 2024-07-01 stuartmorgan@google.com [google_maps_flutter] Semi-convert remaining Android host API calls to Pigeon (flutter/packages#6980) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/local_auth/local_auth_android/android (flutter/packages#7022) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.0 in /packages/video_player/video_player_android/android (flutter/packages#6931) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.0 in /packages/camera/camera_android/android (flutter/packages#6928) 2024-07-01 matanlurey@users.noreply.github.com [ci] Adds @matanlurey to some Android CODEOWNERS until Impeller is enabled. (flutter/packages#7014) 2024-06-29 ditman@gmail.com [video_player] Bumps web implementation dependency. (flutter/packages#7015) 2024-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 15f95ce to 651a17d (7 revisions) (flutter/packages#7013) 2024-06-28 36687028+phong010198@users.noreply.github.com [flutter_markdown] Add horizontal scroll for markdown table (flutter/packages#6983) 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/packages#6709) 2024-06-28 stuartmorgan@google.com [google_maps_flutter] Fix Obj-C type handling (flutter/packages#7010) 2024-06-28 engine-flutter-autoroll@skia.org Manual roll Flutter from e726eb4 to 15f95ce (48 revisions) (flutter/packages#7002) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
flutter/packages@412ec46...d2705fb 2024-07-01 engine-flutter-autoroll@skia.org Roll Flutter from 651a17d to 99bb2ff (10 revisions) (flutter/packages#7038) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7032) 2024-07-01 stuartmorgan@google.com [google_maps_flutter] Semi-convert remaining Android host API calls to Pigeon (flutter/packages#6980) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/local_auth/local_auth_android/android (flutter/packages#7022) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.0 in /packages/video_player/video_player_android/android (flutter/packages#6931) 2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.0 in /packages/camera/camera_android/android (flutter/packages#6928) 2024-07-01 matanlurey@users.noreply.github.com [ci] Adds @matanlurey to some Android CODEOWNERS until Impeller is enabled. (flutter/packages#7014) 2024-06-29 ditman@gmail.com [video_player] Bumps web implementation dependency. (flutter/packages#7015) 2024-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 15f95ce to 651a17d (7 revisions) (flutter/packages#7013) 2024-06-28 36687028+phong010198@users.noreply.github.com [flutter_markdown] Add horizontal scroll for markdown table (flutter/packages#6983) 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/packages#6709) 2024-06-28 stuartmorgan@google.com [google_maps_flutter] Fix Obj-C type handling (flutter/packages#7010) 2024-06-28 engine-flutter-autoroll@skia.org Manual roll Flutter from e726eb4 to 15f95ce (48 revisions) (flutter/packages#7002) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. until flutter/flutter#151018 is completed.
I know this is not foolproof, but I'm hoping it at least keeps me on top of whatever needs to change in the meantime.