- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.5k
 
[flutter_plugin_tools] Allow disabling Swift Package Manager when building examples #7145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            auto-submit
  merged 1 commit into
  flutter:main
from
loic-sharma:build_examples_disable_spm
  
      
      
   
  Jul 18, 2024 
      
    
                
     Merged
            
            [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples #7145
                    auto-submit
  merged 1 commit into
  flutter:main
from
loic-sharma:build_examples_disable_spm
  
      
      
   
  Jul 18, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    da472c7    to
    3cf1331      
    Compare
  
    
              
                    stuartmorgan-g
  
              
              approved these changes
              
                  
                    Jul 18, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Jul 18, 2024 
    
    
      
  
    
      
    
  
…when building examples (flutter/packages#7145)
    
  auto-submit bot
      pushed a commit
        to flutter/flutter
      that referenced
      this pull request
    
      Jul 18, 2024 
    
    
      
  
    
      
    
  
flutter/packages@d03b1b4...c7f0526 2024-07-18 737941+loic-sharma@users.noreply.github.com [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145) 2024-07-17 rexios80@me.com Modernize all `index.html` files to support WASM (flutter/packages#7114) 2024-07-17 louisehsu@google.com [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105) 2024-07-17 ditman@gmail.com [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128) 2024-07-17 30872003+misos1@users.noreply.github.com [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      
        
      
      
  
    11 tasks
  
    
  TytaniumDev 
      pushed a commit
        to TytaniumDev/flutter
      that referenced
      this pull request
    
      Aug 7, 2024 
    
    
      
  
    
      
    
  
flutter/packages@d03b1b4...c7f0526 2024-07-18 737941+loic-sharma@users.noreply.github.com [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145) 2024-07-17 rexios80@me.com Modernize all `index.html` files to support WASM (flutter/packages#7114) 2024-07-17 louisehsu@google.com [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105) 2024-07-17 ditman@gmail.com [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128) 2024-07-17 30872003+misos1@users.noreply.github.com [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    
  Buchimi 
      pushed a commit
        to Buchimi/flutter
      that referenced
      this pull request
    
      Sep 2, 2024 
    
    
      
  
    
      
    
  
flutter/packages@d03b1b4...c7f0526 2024-07-18 737941+loic-sharma@users.noreply.github.com [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145) 2024-07-17 rexios80@me.com Modernize all `index.html` files to support WASM (flutter/packages#7114) 2024-07-17 louisehsu@google.com [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105) 2024-07-17 ditman@gmail.com [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121) 2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128) 2024-07-17 30872003+misos1@users.noreply.github.com [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
You can use the Flutter plugin tool to build the plugins' examples apps. Currently, the tool can enable the Swift Package Manager feature.
This change allows the tool to disable the Swift Package Manager feature. This will be useful for when SPM is enabled by default on a release channel.
Preparation for: flutter/flutter#151567
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.