Skip to content

[shared_preferences] fix stringlist bug #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Aug 1, 2024
Merged

[shared_preferences] fix stringlist bug #7268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5840fba
fix stringlist bug
tarrinneal Aug 1, 2024
1ee44d6
fix the right thing
tarrinneal Aug 1, 2024
266f649
Update CHANGELOG.md
stuartmorgan-g Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/shared_preferences/shared_preferences/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.3.1

* Fixes `getStringList` bug with `List<Object?>` cast exception.

## 2.3.0

* Adds `SharedPreferencesAsync` and `SharedPreferencesWithCache` APIs.
Expand Down
11 changes: 11 additions & 0 deletions ...ared_preferences/shared_preferences/example/integration_test/shared_preferences_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,17 @@ void main() {
expect(preferences.getStringList(listKey), testList);
});

testWidgets('get StringList handles List<Object?>',
(WidgetTester _) async {
final (
SharedPreferencesWithCache preferences,
Map<String, Object?> cache
) = await getPreferences();
final List<Object?> listObject = <Object?>['one', 'two'];
cache[listKey] = listObject;
expect(preferences.getStringList(listKey), listObject);
});

testWidgets('reloading', (WidgetTester _) async {
final (
SharedPreferencesWithCache preferences,
Expand Down
3 changes: 1 addition & 2 deletions packages/shared_preferences/shared_preferences/lib/src/shared_preferences_async.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,8 @@ class SharedPreferencesWithCache {
throw ArgumentError(
'$key is not included in the PreferencesFilter allowlist');
}
final List<String>? list = _cache[key] as List<String>?;
// Make a copy of the list so that later mutations won't propagate
return list?.toList();
return (_cache[key] as List<Object?>?)?.cast<String>().toList();
}

/// Saves a boolean [value] to the cache and platform.
Expand Down
2 changes: 1 addition & 1 deletion packages/shared_preferences/shared_preferences/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for reading and writing simple key-value pairs.
Wraps NSUserDefaults on iOS and SharedPreferences on Android.
repository: https://github.com/flutter/packages/tree/main/packages/shared_preferences/shared_preferences
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+shared_preferences%22
version: 2.3.0
version: 2.3.1

environment:
sdk: ^3.3.0
Expand Down