[in_app_purchase_storekit] Add support for purchase and transactions #7574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
changed the title
hellohuanlin
reviewed
Oct 2, 2024
| @@ -27,6 +27,10 @@ public class InAppPurchasePlugin: NSObject, FlutterPlugin, InAppPurchaseAPI { | |||
| // This property is optional, as it requires self to exist to be initialized. | |||
| public var paymentQueueHandler: FLTPaymentQueueHandlerProtocol? | |||
|
|
|||
| // This should be an Task, but Task is on available >= iOS 13 | |||
| var updateListenerTask: Any? | |||
There was a problem hiding this comment.
can you try out that getter trick discussed yesterday?
packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift
Outdated
Show resolved
Hide resolved
..._app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/InAppPurchaseStoreKit2.swift
Outdated
Show resolved
Hide resolved
..._app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/InAppPurchaseStoreKit2.swift
Outdated
Show resolved
Hide resolved
| } | ||
| case .pending: | ||
| completion( | ||
| .failure( |
There was a problem hiding this comment.
reduce indentation by combining these
There was a problem hiding this comment.
the formatter uncombines these
There was a problem hiding this comment.
strange. it's clearly less than 100 characters. how's your code like before the formatter?
| @MainActor in | ||
| do { | ||
| let transactionsMsgs = await rawTransactions().map { | ||
| $0.convertToPigeon() |
There was a problem hiding this comment.
"Keypath can’t be used on instance methods"
..._app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/InAppPurchaseStoreKit2.swift
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /// Helper function to cast updateListenerTask to a task | ||
| func getUpdateListenerTask() -> Task<(), Never> { |
There was a problem hiding this comment.
can you use a getter (rather than a function) in the class definition (rather than extension). And make updateListenerTask private.
..._purchase/in_app_purchase_storekit/example/shared/RunnerTests/StoreKit2TranslatorTests.swift
Outdated
Show resolved
Hide resolved
| @testable import in_app_purchase_storekit | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, *) | ||
| class StoreKit2TranslatorTests: XCTestCase { |
hellohuanlin
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.