Skip to content

[camerax] Ignore new unreachable_switch_default warning. #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stereotype441 merged 1 commit into from
Sep 9, 2024
Merged

[camerax] Ignore new unreachable_switch_default warning. #7592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/lib/src/capture_request_options.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class _CaptureRequestOptionsHostApiImpl extends CaptureRequestOptionsHostApi {
// This ignore statement is safe beause this error will be useful when
// a new CaptureRequestKeySupportedType is being added, but the logic in
// this method has not yet been updated.
// ignore: no_default_cases
// ignore: no_default_cases, unreachable_switch_default
default:
throw ArgumentError(CaptureRequestOptions
.getUnsupportedCaptureRequestKeyTypeErrorMessage(key));
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/lib/src/live_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ class LiveDataFlutterApiImpl implements LiveDataFlutterApi {
// This ignore statement is safe beause this error will be useful when
// a new LiveDataSupportedType is being added, but the logic in this method
// has not yet been updated.
// ignore: no_default_cases
// ignore: no_default_cases, unreachable_switch_default
default:
throw ArgumentError(LiveData.unsupportedLiveDataTypeErrorMessage);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/test/capture_request_options_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ void main() {
// This ignore statement is safe beause this will test when
// a new CaptureRequestKeySupportedType is being added, but the logic in
// in the CaptureRequestOptions class has not yet been updated.
// ignore: no_default_cases
// ignore: no_default_cases, unreachable_switch_default
default:
fail(
'Option $option contains unrecognized CaptureRequestKeySupportedType key ${option.$1}');
Expand Down