Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package:flutter_lints] update the dep on package:lints to 5.0.0 and the sdk dependency to 3.5.0 #7704

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

devoncarew
Copy link
Member

  • rev package:flutter_lints to 5.0.0 in prep for publishing
  • update our dep on package:lints to the latest stable published version (5.0.0)
  • update our sdk dep to reflect the package:lints one
  • update the changelog to reflect the new changes brought in from package:lints

Closes dart-lang/lints#205.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@devoncarew
Copy link
Member Author

@stuartmorgan for review (and cc @Piinks and @goderbauer for fyi)

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Sep 25, 2024

rev to 5.0.0 in prep for publishing

In flutter/packages this doesn't prepare for publishing, landing this PR actually publishes the package. We generally give the PR a name describing the change itself rather than the version change (e.g., "[flutter_lints] Update lints to 5.0 and adjust additional lints") to make the history more informative.

@devoncarew devoncarew changed the title [package:flutter_lints] rev to 5.0.0 in prep for publishing [package:flutter_lints] update the dep on package:lints to 5.0.0 and the sdk dependency to 3.5.0 Sep 25, 2024
@devoncarew
Copy link
Member Author

We generally give the PR a name describing the change itself rather than the version change (e.g., "[flutter_lints] Update lints to 5.0 and adjust additional lints") to make the history more informative.

👍 ; updated the title to [package:flutter_lints] update the dep on package:lints to 5.0.0 and the sdk dependency to 3.5.0.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changelog style nit

packages/flutter_lints/CHANGELOG.md Outdated Show resolved Hide resolved
@devoncarew devoncarew merged commit f38b780 into flutter:main Sep 25, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 26, 2024
flutter/packages@7da2374...f38b780

2024-09-25 devoncarew@google.com [package:flutter_lints] update the dep on `package:lints` to 5.0.0 and the sdk dependency to 3.5.0 (flutter/packages#7704)
2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter from 4ca51a1 to 538e742 (40 revisions) (flutter/packages#7705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the annoying const lints from flutter_lints
2 participants