[interactive_media_ads] Change the location of where the AdsLoader is initialized #7721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 1, 2024
…oader is initialized (flutter/packages#7721)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 1, 2024
…oader is initialized (flutter/packages#7721)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 1, 2024
flutter/packages@27c9853...ebcc4f0 2024-10-01 43054281+camsim99@users.noreply.github.com [camerax] Correct assumption about preview being correctly rotated by default on API 29 (flutter/packages#7714) 2024-09-30 43759233+kenzieschmoll@users.noreply.github.com Replace `initialPage` parameter with `benchmarkPath` (flutter/packages#7743) 2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.11.0 to 1.12.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7681) 2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.35.0 to 3.35.1 in /packages/interactive_media_ads/android (flutter/packages#7734) 2024-09-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Change the location of where the AdsLoader is initialized (flutter/packages#7721) 2024-09-30 stuartmorgan@google.com [file_selector] Update Windows Pigeon for non-nullable generics (flutter/packages#7730) 2024-09-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `AdProgressInfo` (flutter/packages#7723) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the creation of
AdsLoaderto theonContainerAddedcallback. This makes it clearer that theAdsLoaderonly needs to be created once.This also changes the default value for
_shouldShowContentVideotofalseto prevent the content video from showing before the first ad. I verified this still works even when no pre-roll ads are loaded.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.