[webview_flutter] Add an option to bypass SSL checks #7893
Conversation
# Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/pubspec.yaml # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/lib/src/foundation/foundation.dart
|
I still have some tests to add, but I would like a first pass to check for bigger issues |
Colman
requested review from
cbracken,
bparrishMines and
ditman
as code owners
Those changes are needed temporarily because this is a federated plugin. Please see: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins |
|
This is blocked by the |
|
from triage: iOS proxy updates are close to landing, at which point this will finally be unblocked. |
|
@bparrishMines Can you take a look at updating this to the new wrapper? |
…dates native wrapper for `SecTrust` and `SecCertificate` (#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing #7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
|
Greetings from stale PR triage, @stuartmorgan-g is this one still blocked? |
|
No, it's unblocked now and needs to be updated to the new wrapper generator. @bparrishMines is planning on doing that, but has been on higher priority work. It should be pretty soon though. |
…dates native wrapper for `SecTrust` and `SecCertificate` (flutter#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing flutter#7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…ebViewClient`. (flutter#8964) This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
|
This PR doesn't allow me to edit so I took over this feature with: #9150. Closing. |
When the webview encounters an SSL error, there is no option to be able to bypass the error. This PR implements a callback that gets called with the SSL error and certificate details. A decision can be returned to either ignore the error and proceed, or cancel the request.
flutter/flutter#36925
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.