[in_app_purchase_storekit] Remove unneeded platform annotations #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested changes
Oct 24, 2024
|
|
||
| /// If StoreKit has called your SKPaymentQueueDelegate's "paymentQueueShouldShowPriceConsent:" | ||
| /// method and you returned NO, you can use this method to show the price consent UI at a later time | ||
| /// that is more appropriate for your app. If there is no pending price consent, this method will do | ||
| /// nothing. | ||
| - (void)showPriceConsentIfNeeded API_AVAILABLE(ios(13.4), visionos(1.0)) | ||
| API_UNAVAILABLE(tvos, macos, watchos); | ||
| - (void)showPriceConsentIfNeeded API_AVAILABLE(ios(13.4))API_UNAVAILABLE(tvos, macos, watchos); |
There was a problem hiding this comment.
In other places you removed watchos; we should either only remove visionos everywhere, since that's the problem, or we should remove watchos and tvos everywhere.
There was a problem hiding this comment.
thats fair. let me put them back.
There was a problem hiding this comment.
oh i see you edited your comment. Do you mean I should also remove watchos and tvos from API_UNAVAILABLE?
There was a problem hiding this comment.
Putting them back is fine; I edited my comment because I meant to say that we should be consistent one way or the other—either list watchos and tvos everywhere, or don't list them anywhere—but what I actually wrote was the same option two different phrased ways.
|
From triage: @LouiseHsu I believe this is still waiting for a minor update based on my last comments? |
sorry! i lost track of this |
stuartmorgan
approved these changes
Nov 13, 2024
LouiseHsu
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2024
flutter/packages@26e123a...b9ac917 2024-11-13 louisehsu@google.com [in_app_purchase_storekit] Fixes manual invocation of `finishTransaction()` triggering fatal crash (flutter/packages#8071) 2024-11-13 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7988) 2024-11-13 louisehsu@google.com [in_app_purchase_storekit] Remove unneeded platform annotations (flutter/packages#7914) 2024-11-13 stuartmorgan@google.com [tool] Improve Swift lint error message (flutter/packages#8074) 2024-11-13 engine-flutter-autoroll@skia.org Roll Flutter from c8510f2 to ed553d1 (48 revisions) (flutter/packages#8076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#155213
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).