[web_benchmarks] Remove WebRenderer enum.
#8103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: removing code |
yjbanov
approved these changes
Nov 15, 2024
auto-submit
bot
removed
the
autosubmit
7 tasks
auto-submit bot
pushed a commit
to flutter/devtools
that referenced
this pull request
Nov 15, 2024
This change is in preparation of the removal of `--web-renderer=html`. * Related: flutter/packages#8103 (tooling change to remove the parameter from the benchmark runner) * Related: flutter/flutter#145954 (general thread) ## Tests In this case, CI should continue normally. The change is just adopting a new major version of `package:web_benchmarks` that removed some public API (that wasn't used in devtools). ![build.yaml badge] If you need help, consider asking for help on [Discord]. [build.yaml badge]: https://github.com/flutter/devtools/actions/workflows/build.yaml/badge.svg
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2024
flutter/packages@b164be3...c1eabf5 2024-11-16 49699333+dependabot[bot]@users.noreply.github.com [gradle]: Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.4.0 in /packages/interactive_media_ads/android (flutter/packages#8095) 2024-11-16 kevmoo@users.noreply.github.com [google_identity_services_web] Migrate all types to JSObject (flutter/packages#8053) 2024-11-15 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7982) 2024-11-15 ditman@gmail.com [web_benchmarks] Remove `WebRenderer` enum. (flutter/packages#8103) 2024-11-15 kevmoo@users.noreply.github.com [google_maps_flutter] Fix detection of WebAssembly compatibility (flutter/packages#8102) 2024-11-15 engine-flutter-autoroll@skia.org Roll Flutter from ed553d1 to 0e2d55e (40 revisions) (flutter/packages#8106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
WebRendererenum, and its uses in theCompilationOptionsclass.This is a breaking change because it's removing public API (
CompilationOptions.renderer,WebRenderer), but in practice people shouldn't need any changes to their code (since theCompilationOptionsclass is used through named constructors). In any case, labeling asv4.0.0.Related: flutter/flutter#145954
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.