Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera_android_camerax]: Bump camerax_version from 1.3.4 to 1.4.0 in /packages/camera/camera_android_camerax/android #8165

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 25, 2024

Bumps camerax_version from 1.3.4 to 1.4.0.
Updates androidx.camera:camera-core from 1.3.4 to 1.4.0

Updates androidx.camera:camera-camera2 from 1.3.4 to 1.4.0

Updates androidx.camera:camera-lifecycle from 1.3.4 to 1.4.0

Updates androidx.camera:camera-video from 1.3.4 to 1.4.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `camerax_version` from 1.3.4 to 1.4.0.

Updates `androidx.camera:camera-core` from 1.3.4 to 1.4.0

Updates `androidx.camera:camera-camera2` from 1.3.4 to 1.4.0

Updates `androidx.camera:camera-lifecycle` from 1.3.4 to 1.4.0

Updates `androidx.camera:camera-video` from 1.3.4 to 1.4.0

---
updated-dependencies:
- dependency-name: androidx.camera:camera-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.camera:camera-camera2
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.camera:camera-lifecycle
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.camera:camera-video
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from camsim99 as a code owner November 25, 2024 08:27
@dependabot dependabot bot added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2024
Copy link
Contributor

auto-submit bot commented Nov 25, 2024

auto label is removed for flutter/packages/8165, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2024
@camsim99 camsim99 changed the title [gradle]: Bump camerax_version from 1.3.4 to 1.4.0 in /packages/camera/camera_android_camerax/android [camera_android_camerax]: Bump camerax_version from 1.3.4 to 1.4.0 in /packages/camera/camera_android_camerax/android Dec 2, 2024
@camsim99
Copy link
Contributor

camsim99 commented Dec 2, 2024

Landing this will require a bump to the legacy all_packages Gradle/AGP bump. This is also blocking at least one other dependabot upgrade: #8047.

@stuartmorgan to clarify, it's okay to modify legacy_project now that we get the clear error messages like the one here?
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8730311358793597233/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout

@stuartmorgan
Copy link
Contributor

@stuartmorgan to clarify, it's okay to modify legacy_project now that we get the clear error messages like the one here?

Are you referring to the "Warning: Flutter support for your project's Android Gradle Plugin version (7.0.0) will soon be dropped" messages? Those look like they are messages about resolving the warnings, not the build error (in this case I assume it would resolve the error, but that's not at all clear from the output). Ideally we would have something much clearer before we updated the legacy project. Usually that's one of the post-failure Flutter Fix messages that clearly says what to do to fix the error.

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 18, 2024

Superseded by #8330.

@dependabot dependabot bot closed this Dec 18, 2024
@dependabot dependabot bot deleted the dependabot/gradle/packages/camera/camera_android_camerax/android/camerax_version-1.4.0 branch December 18, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants