Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk constraints #8345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk constraints #8345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions script/tool/lib/src/create_all_packages_app_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,9 @@ dependencies {}
gradleFile,
replacements: <String, List<String>>{
if (gradleFileIsKotlin)
'compileSdk': <String>['compileSdk = 34']
'compileSdk': <String>['compileSdk = flutter.compileSdkVersion']
else ...<String, List<String>>{
'compileSdkVersion': <String>['compileSdk 34'],
'compileSdkVersion': <String>['compileSdk flutter.compileSdkVersion'],
}
},
regexReplacements: <RegExp, List<String>>{
Expand Down
4 changes: 2 additions & 2 deletions script/tool/test/create_all_packages_app_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ android {
buildGradle,
containsAll(<Matcher>[
contains('This is the legacy file'),
contains('compileSdk 34'),
contains('compileSdk flutter.compileSdkVersion'),
]));
});

Expand Down Expand Up @@ -375,7 +375,7 @@ android {
expect(
buildGradle,
containsAll(<Matcher>[
contains('compileSdk 34'),
contains('compileSdk flutter.compileSdkVersion'),
contains('androidx.lifecycle:lifecycle-runtime'),
]));
});
Expand Down
Loading