[google_sign_in] Add Android account name field as optional #8573
+236
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… account name. This capability is only available within Android for the underlying libraries.
neilself
requested review from
loic-sharma,
camsim99,
ditman and
stuartmorgan
as code owners
github-actions
bot
added
p: google_sign_in
platform-android
platform-ios
platform-web
labels
|
Apologies, I didn't mean to request review just yet. |
stuartmorgan
removed request for
stuartmorgan,
loic-sharma,
ditman and
camsim99
|
Marked as draft; once it's ready, just press the "Ready for review" button and it will re-active all the code owner review requests. |
…nstruction to test the account being constructed in the builder and then passed into GoogleSignInOptions. This is necessary as Account is an android class and cannot be instantiated normally in a unit test (the constructor will return null).
…due to platform interface changes in google_sign_in.
…e to platform interface changes in google_sign_in_platform_interface.
…ample due to platform interface changes in google_sign_in_platform_interface.
…sign_in_as_googleapis_auth for new change adding an optional account name field for Android sign-in.
|
Marking this as ready for review now, as tests seem to be passing other than the one about federated plugin dependencies. Also, I'm not sure about linking an issue, as flutter/packages doesn't seem to even have the issues tab. Do I just create an issue on the main flutter repo? |
stuartmorgan
requested changes
Feb 20, 2025
packages/extension_google_sign_in_as_googleapis_auth/CHANGELOG.md
Outdated
Show resolved
Hide resolved
.../google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart
Outdated
Show resolved
Hide resolved
packages/google_sign_in/google_sign_in_platform_interface/lib/src/types.dart
Outdated
Show resolved
Hide resolved
packages/google_sign_in/google_sign_in_android/example/android/app/build.gradle
Outdated
Show resolved
Hide resolved
..._sign_in_android/android/src/test/java/io/flutter/plugins/googlesignin/GoogleSignInTest.java
Outdated
Show resolved
Hide resolved
…on thrown in corresponding code.
camsim99
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying Android library for google_sign_in allows for explicitly specifying an account name, but google_sign_in doesn't have a passthrough field for this. Android clients who want to use this functionality through google_sign_in are unable. This PR would remedy this by adding a passthrough field to expose this functionality.
Flutter issue: 163257
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.