Skip to content

Conversation

@sysint64
Copy link
Contributor

@sysint64 sysint64 commented Apr 3, 2025

Fixes #158735

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@sysint64 sysint64 requested a review from jonahwilliams as a code owner April 3, 2025 13:32
@sysint64 sysint64 changed the title [vector_graphics_compiler] fix: Stroke opacity not applied #158735 [vector_graphics_compiler] fix: Stroke opacity not applied Apr 3, 2025
@sysint64
Copy link
Contributor Author

sysint64 commented Apr 3, 2025

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please correct the formatting issues so we can merge.

@sysint64
Copy link
Contributor Author

@jonahwilliams Fixed

@jonahwilliams
Copy link
Contributor

Sorry, another PR landed, can you resolve the merge conflict?

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once conflicts are fixed

@sysint64
Copy link
Contributor Author

LGTM once conflicts are fixed

Done

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 22, 2025
@auto-submit auto-submit bot merged commit f1fc965 into flutter:main Apr 22, 2025
82 checks passed
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Apr 22, 2025
flutter/packages@ac21f53...f1fc965

2025-04-22 sys.int64@gmail.com [vector_graphics_compiler] fix: Stroke
opacity not applied (flutter/packages#8986)
2025-04-21 edpizzi@gmail.com [in_app_purchase] Write to the transactions
update queue from the main thread (flutter/packages#9068)
2025-04-21 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Add `caseSensitive` to `TypedGoRoute`
(flutter/packages#9096)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
raju-muliyashiya pushed a commit to raju-muliyashiya/flutter_packages that referenced this pull request Apr 26, 2025
)

Fixes [#158735](flutter/flutter#158735)

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
)

Fixes [#158735](flutter/flutter#158735)

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
)

Fixes [#158735](flutter/flutter#158735)

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
)

Fixes [#158735](flutter/flutter#158735)

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
…r#167560)

flutter/packages@ac21f53...f1fc965

2025-04-22 sys.int64@gmail.com [vector_graphics_compiler] fix: Stroke
opacity not applied (flutter/packages#8986)
2025-04-21 edpizzi@gmail.com [in_app_purchase] Write to the transactions
update queue from the main thread (flutter/packages#9068)
2025-04-21 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Add `caseSensitive` to `TypedGoRoute`
(flutter/packages#9096)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: vector_graphics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_svg] Stroke opacity not applied

3 participants