-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Native ads request #9663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Native ads request #9663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively expands the AdsRequest
API for both Android and iOS, providing more control over ad requests. The changes are well-implemented across Dart, Kotlin, and Swift, with corresponding updates to Pigeon definitions and comprehensive tests. The upgrade to a newer Pigeon version also introduces beneficial changes for testability. I have one minor suggestion to improve the robustness of the Swift implementation by replacing a force cast with a safer conditional cast. I've referenced the Flutter style guide in my review comment.
throw (pigeonApi.pigeonRegistrar.apiDelegate as! ProxyApiDelegate) | ||
.createConstructorNullError(type: URL.Type.self, parameters: ["string": contentURL]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a force cast as!
can lead to a runtime crash if the type cast fails. For better robustness and maintainability, it's recommended to use a conditional cast as?
with a guard
statement to safely unwrap the delegate.
guard let proxyApiDelegate = pigeonApi.pigeonRegistrar.apiDelegate as? ProxyApiDelegate else {
throw PigeonError(
code: "cast-error",
message: "apiDelegate is not of type ProxyApiDelegate.",
details: nil)
}
throw proxyApiDelegate.createConstructorNullError(
type: URL.Type.self, parameters: ["string": contentURL])
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3