[tool] Combine code analysis commands into `analyze` #9860

stuartmorgan-g · 2025-08-20T18:57:01Z

Folds native code analysis commands into analyze to simplify the set of commands:

lint-android is now analyze --no-dart --android
xcode-analyze --ios is now analyze --no-dart --ios
xcode-analyze --macos is now analyze --no-dart --macos

In practice --no-dart is mostly there for CI; Dart analysis is fast enough that for local plugin development the new expected use case would likely be analyze --whateverplatorm, and it will run analysis on all relevant code in the package.

Part of flutter/flutter#173413

Pre-Review Checklist

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

gemini-code-assist

Code Review

This pull request refactors the code analysis tooling by consolidating the lint-android and xcode-analyze commands into a single, more flexible analyze command. This new command allows running Dart and native code analysis for various platforms (Android, iOS, macOS) together or separately, controlled by flags. The changes include updating the AnalyzeCommand to handle different analysis types, removing the old command files, and updating CI configurations and documentation to use the new command. The test suite has also been significantly updated to cover the new unified command's functionality. My review found one critical issue in the CI configuration that needs to be addressed.

.ci/targets/android_platform_tests.yaml

stuartmorgan-g · 2025-08-20T18:58:21Z

script/tool/lib/src/analyze_command.dart

+
+  /// Runs Gradle lint analysis for the given package, and returns the result
+  /// that applies to that analysis.
+  Future<PackageResult> _runGradleLintForPackage(


This is runForPackage from lint_android_command.dart, with essentially no changes beyond renaming.

stuartmorgan-g · 2025-08-20T19:00:45Z

script/tool/lib/src/analyze_command.dart

+  }
+
+  /// Analyzes [plugin] for [targetPlatform].
+  Future<PackageResult> _runXcodeAnalysisForPackage(


This is runForPackage from xcode_analyze_command.dart with some minor changes to make it return a PackageResult, and to include the skip logic that was a level higher in the old command. The result aggregation logic that xcode-analyze had is gone since analyze now has more generic aggregation logic that makes it unnecessary.

stuartmorgan-g · 2025-08-20T19:01:13Z

script/tool/test/analyze_command_test.dart

-    final RepositoryPackage plugin1 = createFakePlugin('a', packagesDir);
-
-    await runCapturingPrint(runner, <String>['analyze']);
+  group('result aggregation', () {


This small test group is new.

stuartmorgan-g · 2025-08-20T19:01:33Z

script/tool/test/analyze_command_test.dart

    runner.addCommand(analyzeCommand);
  });

-  test('analyzes all packages', () async {


All the "removed" code is actually just wrapped in a new 'dart analyze' group.

stuartmorgan-g · 2025-08-20T19:05:30Z

script/tool/test/analyze_command_test.dart


-    test('skips commands if all files should be ignored', () async {
-      createFakePackage('package_a', packagesDir);
+  group('gradle lint', () {


This group is the old lint-android tests, with minor string changes where I changed some logging messages.

stuartmorgan-g · 2025-08-20T19:05:54Z

script/tool/test/analyze_command_test.dart

+  });
+
+  // TODO(stuartmorgan): Separate iOS and macOS.
+  group('Xcode analyze', () {


This is the old xcode-analyze tests with very minor tweaks.

…er/packages#9860)

flutter/packages@3db5adc...5d785a0 2025-09-02 stuartmorgan@google.com [tool] Combine code analysis commands into `analyze` (flutter/packages#9860) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…#174840) flutter/packages@3db5adc...5d785a0 2025-09-02 stuartmorgan@google.com [tool] Combine code analysis commands into `analyze` (flutter/packages#9860) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

stuartmorgan-g added 9 commits August 20, 2025 12:59

Add multi-result structure and a Dart flag

57df7e7

Move existing tests into a group

05eadb1

Test throwing for nothing requested

8e8df00

Fold lint-android into analyze

c7c357b

Add section headers

56c1a0b

Fold xcode-analyze into analyze as-is

d537878

Simplify Xcode analysis since analyze already aggregates results

0f79492

Add aggregation testing

8b2a9db

README

5c5cc7e

stuartmorgan-g requested review from jmagman and reidbaker August 20, 2025 18:57

gemini-code-assist bot reviewed Aug 20, 2025

View reviewed changes

.ci/targets/android_platform_tests.yaml Outdated Show resolved Hide resolved

stuartmorgan-g commented Aug 20, 2025

View reviewed changes

stuartmorgan-g added 2 commits August 20, 2025 15:06

Remove resolved TODO

e65bfdd

Flag fix

8200b1c

This comment was marked as spam.

Sign in to view

reidbaker approved these changes Sep 2, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2025

auto-submit bot merged commit 5d785a0 into flutter:main Sep 2, 2025
80 checks passed

stuartmorgan-g deleted the tool-analyze-combine branch September 2, 2025 17:11

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2025

5d785a06c [tool] Combine code analysis commands into analyze (flutt…

f7d2e1e

…er/packages#9860)

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Packages from 3db5adc6a64b to 5d785a06c091 (1 revision) flutter/flutter#174840

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[tool] Combine code analysis commands into `analyze` #9860

[tool] Combine code analysis commands into `analyze` #9860

Uh oh!

stuartmorgan-g commented Aug 20, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

stuartmorgan-g Aug 20, 2025

Uh oh!

stuartmorgan-g Aug 20, 2025

Uh oh!

stuartmorgan-g Aug 20, 2025

Uh oh!

stuartmorgan-g Aug 20, 2025

Uh oh!

stuartmorgan-g Aug 20, 2025

Uh oh!

stuartmorgan-g Aug 20, 2025

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[tool] Combine code analysis commands into analyze #9860

[tool] Combine code analysis commands into analyze #9860

Uh oh!

Conversation

stuartmorgan-g commented Aug 20, 2025

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

stuartmorgan-g Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[tool] Combine code analysis commands into `analyze` #9860

[tool] Combine code analysis commands into `analyze` #9860