[google_maps_flutter_platform_interface] Add cameraControl enable/disable & position on web #9897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for enabling, disabling, and positioning the camera control button for the web version of Google Maps. This is achieved by adding webCameraControlEnabled and webCameraControlPosition to the MapConfiguration class, along with a new WebCameraControlPosition enum. The changes are consistently integrated throughout the MapConfiguration class, including updates to equality checks, hash code generation, and diffing logic. Corresponding tests have been added to verify the new functionality, and the package version and changelog have been updated. I have found one minor documentation error that should be corrected.
...lutter/google_maps_flutter_platform_interface/lib/src/types/web_camera_control_position.dart
Outdated
Show resolved
Hide resolved
…rface/lib/src/types/web_camera_control_position.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
11 tasks
stuartmorgan-g
requested changes
Aug 27, 2025
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| /// This setting controls how the API handles camera control button on the map |
Collaborator
There was a problem hiding this comment.
Nit: Needs a period at the end.
| // found in the LICENSE file. | ||
|
|
||
| /// This setting controls how the API handles camera control button on the map | ||
| /// See https://developers.google.com/maps/documentation/javascript/reference/control#ControlPosition for more details. |
Collaborator
There was a problem hiding this comment.
Nit: Blank line above this; per Effective Dart style, there should be a blank line after the first sentence in a doc comment.
| // found in the LICENSE file. | ||
|
|
||
| /// This setting controls how the API handles camera control button on the map | ||
| /// See https://developers.google.com/maps/documentation/javascript/reference/control#ControlPosition for more details. |
Collaborator
There was a problem hiding this comment.
Nit: please add a line break after the URL so this line isn't so long.
...lutter/google_maps_flutter_platform_interface/lib/src/types/web_camera_control_position.dart
Show resolved
Hide resolved
...lutter/google_maps_flutter_platform_interface/lib/src/types/web_camera_control_position.dart
Show resolved
Hide resolved
...lutter/google_maps_flutter_platform_interface/lib/src/types/web_camera_control_position.dart
Show resolved
Hide resolved
| inlineStartBlockStart, | ||
|
|
||
| /// Elements are positioned on the left, above bottom-left elements, | ||
| /// and flow upwards. Consider using INLINE_START_BLOCK_END instead. |
Collaborator
There was a problem hiding this comment.
Line break and blank line after the period.
Collaborator
There was a problem hiding this comment.
This applies to all the comments below as well.
stuartmorgan-g
added
federated: partial_changes
harryterkelsen
requested changes
Aug 27, 2025
...e_maps_flutter/google_maps_flutter_platform_interface/test/types/map_configuration_test.dart
Show resolved
Hide resolved
Contributor
Author
|
Hey @harryterkelsen @stuartmorgan-g, I'm unable to merge this pull request, and I have a question about the next step. I'm following the documentation for "Changing federated plugins" and am at step 4, which says: "Once it has been reviewed, landed, and published, update the initial PR..." Who is responsible for landing and publishing the changes? Thanks |
stuartmorgan-g
added
the
autosubmit
Collaborator
|
The Flutter team (generally the last reviewer) lands changes, and a bot publishes them. |
Contributor
Author
thanks @stuartmorgan-g! Once the new version is published, I'll update the other pull request to reflect the changes. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2025
…enable/disable & position on web (flutter/packages#9897)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2025
flutter/packages@141d8e3...a3f09e5 2025-08-28 stuartmorgan@google.com [google_sign_in] Implement hosted domain on Android (flutter/packages#9871) 2025-08-28 monteiroamelo@gmail.com [google_maps_flutter_platform_interface] Add cameraControl enable/disable & position on web (flutter/packages#9897) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…r#174706) flutter/packages@141d8e3...a3f09e5 2025-08-28 stuartmorgan@google.com [google_sign_in] Implement hosted domain on Android (flutter/packages#9871) 2025-08-28 monteiroamelo@gmail.com [google_maps_flutter_platform_interface] Add cameraControl enable/disable & position on web (flutter/packages#9897) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
…r#174706) flutter/packages@141d8e3...a3f09e5 2025-08-28 stuartmorgan@google.com [google_sign_in] Implement hosted domain on Android (flutter/packages#9871) 2025-08-28 monteiroamelo@gmail.com [google_maps_flutter_platform_interface] Add cameraControl enable/disable & position on web (flutter/packages#9897) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
…r#174706) flutter/packages@141d8e3...a3f09e5 2025-08-28 stuartmorgan@google.com [google_sign_in] Implement hosted domain on Android (flutter/packages#9871) 2025-08-28 monteiroamelo@gmail.com [google_maps_flutter_platform_interface] Add cameraControl enable/disable & position on web (flutter/packages#9897) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform interface portion of #9089.
Part of flutter/flutter#167137
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3