Skip to content

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Sep 2, 2025

#9853 bumped it to 23, so updating the README.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum Android SDK version in the camera package's README from 21 to 23. While the change in the support table is correct, I've pointed out that the Android setup instructions in the same file still refer to SDK 21. I've recommended updating this section as well to ensure the documentation is consistent and to prevent confusion for developers.

| | Android | iOS | Web |
|----------------|---------|-----------|------------------------|
| **Support** | SDK 21+ | iOS 12.0+ | [See `camera_web `][1] |
| **Support** | SDK 23+ | iOS 12.0+ | [See `camera_web `][1] |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this update to SDK 23 in the support table is correct, the Android setup instructions further down in this file (lines 40-44) still refer to minSdkVersion 21. To maintain consistency and avoid user confusion, please update that section to minSdkVersion 23 as well.

Co-authored-by: jesswrd <jessiewong401@gmail.com>
@camsim99 camsim99 added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 2, 2025
@camsim99
Copy link
Contributor Author

camsim99 commented Sep 2, 2025

Overriding version/changelog since this is a docs only change.

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2025
@auto-submit auto-submit bot merged commit 73eeb2b into flutter:main Sep 2, 2025
80 checks passed
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Sep 3, 2025
flutter/packages@5d785a0...42bb347

2025-09-03 james@somethingwild.co.nz [google_maps_flutter] Fixes
exception when dispose is called while asynchronous update from
didUpdateWidget is executed (flutter/packages#9227)
2025-09-03 monteiroamelo@gmail.com [google_maps_flutter] Add
cameraControl enable/disable & position on web (flutter/packages#9089)
2025-09-03 stuartmorgan@google.com [tool] Only license-check checked-in
files (flutter/packages#9905)
2025-09-03 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes preloading ad while another was playing on
Android (flutter/packages#9904)
2025-09-02 31859944+LongCatIsLooong@users.noreply.github.com Update
FWFWebViewFlutterWKWebViewExternalAPITests.swift (flutter/packages#9922)
2025-09-02 31859944+LongCatIsLooong@users.noreply.github.com Update
Stubs for FlutterPluginRegistrar interface change
(flutter/packages#9923)
2025-09-02 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Update Android minimum SDK version
(flutter/packages#9945)
2025-09-02 engine-flutter-autoroll@skia.org Roll Flutter from
da5523a to 6b18740 (49 revisions) (flutter/packages#9926)
2025-09-02 stuartmorgan@google.com [various] Scrub pre-iOS-13 code
(flutter/packages#9849)
2025-09-02 monteiroamelo@gmail.com [google_maps_flutter_web] Add
cameraControl enable/disable & position on web (flutter/packages#9921)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…er#174876)

flutter/packages@5d785a0...42bb347

2025-09-03 james@somethingwild.co.nz [google_maps_flutter] Fixes
exception when dispose is called while asynchronous update from
didUpdateWidget is executed (flutter/packages#9227)
2025-09-03 monteiroamelo@gmail.com [google_maps_flutter] Add
cameraControl enable/disable & position on web (flutter/packages#9089)
2025-09-03 stuartmorgan@google.com [tool] Only license-check checked-in
files (flutter/packages#9905)
2025-09-03 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes preloading ad while another was playing on
Android (flutter/packages#9904)
2025-09-02 31859944+LongCatIsLooong@users.noreply.github.com Update
FWFWebViewFlutterWKWebViewExternalAPITests.swift (flutter/packages#9922)
2025-09-02 31859944+LongCatIsLooong@users.noreply.github.com Update
Stubs for FlutterPluginRegistrar interface change
(flutter/packages#9923)
2025-09-02 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Update Android minimum SDK version
(flutter/packages#9945)
2025-09-02 engine-flutter-autoroll@skia.org Roll Flutter from
da5523a to 6b18740 (49 revisions) (flutter/packages#9926)
2025-09-02 stuartmorgan@google.com [various] Scrub pre-iOS-13 code
(flutter/packages#9849)
2025-09-02 monteiroamelo@gmail.com [google_maps_flutter_web] Add
cameraControl enable/disable & position on web (flutter/packages#9921)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
…er#174876)

flutter/packages@5d785a0...42bb347

2025-09-03 james@somethingwild.co.nz [google_maps_flutter] Fixes
exception when dispose is called while asynchronous update from
didUpdateWidget is executed (flutter/packages#9227)
2025-09-03 monteiroamelo@gmail.com [google_maps_flutter] Add
cameraControl enable/disable & position on web (flutter/packages#9089)
2025-09-03 stuartmorgan@google.com [tool] Only license-check checked-in
files (flutter/packages#9905)
2025-09-03 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes preloading ad while another was playing on
Android (flutter/packages#9904)
2025-09-02 31859944+LongCatIsLooong@users.noreply.github.com Update
FWFWebViewFlutterWKWebViewExternalAPITests.swift (flutter/packages#9922)
2025-09-02 31859944+LongCatIsLooong@users.noreply.github.com Update
Stubs for FlutterPluginRegistrar interface change
(flutter/packages#9923)
2025-09-02 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Update Android minimum SDK version
(flutter/packages#9945)
2025-09-02 engine-flutter-autoroll@skia.org Roll Flutter from
da5523a to 6b18740 (49 revisions) (flutter/packages#9926)
2025-09-02 stuartmorgan@google.com [various] Scrub pre-iOS-13 code
(flutter/packages#9849)
2025-09-02 monteiroamelo@gmail.com [google_maps_flutter_web] Add
cameraControl enable/disable & position on web (flutter/packages#9921)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants