[interactive_media_ads] Adds support for accessing data for an Ad #9972
Conversation
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
bparrishMines
changed the title
|
The new files here will need to be updated to remove the "All rights reserved" to pass checks post-merge. |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Minor comments, but otherwise LGTM
| final String? apiFramework; | ||
|
|
||
| /// The height of the companion in pixels. | ||
| final int? height; |
There was a problem hiding this comment.
What do null height/width mean?
There was a problem hiding this comment.
It means that it is unavailable: https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/api/reference/com/google/ads/interactivemedia/v3/api/CompanionAd#getWidth(). I change the zero to null to avoid foot guns. I'll update docs.
| final String? resourceValue; | ||
|
|
||
| /// The width of the companion in pixels. | ||
| final int? width; |
There was a problem hiding this comment.
Height and width should probably be together in the member list and the constructor params.
| final PlatformAd platform; | ||
|
|
||
| /// The ad ID as specified in the VAST response. | ||
| String get adId => platform.adId; |
There was a problem hiding this comment.
This is inconsistent with the previous file's capitalization of ID; the Dart API surface should consistently use one or the other. (Same with other names below.)
There was a problem hiding this comment.
Good catch. Android and iOS use different capitalization so I end up switching on accident. It looks like the precedent is already to use lowercase so I updated the other values.
| int get vastMediaWidth => platform.vastMediaWidth; | ||
|
|
||
| /// The width of the selected creative if non-linear, else returns 0. | ||
| int get width => platform.width; |
There was a problem hiding this comment.
Why are width and height so far apart?
There was a problem hiding this comment.
I was doing it in the same order as Android and it looks like they order methods alphabetically: https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/api/reference/com/google/ads/interactivemedia/v3/api/Ad
It does makes since to have these two together though.
| /// a playlist. | ||
| /// | ||
| /// DAI live stream: For a preroll pod, returns 0. For midrolls, returns the | ||
| /// break ID. Returns -2 if pod index cannot be determined (internal error). |
There was a problem hiding this comment.
Can we make constants for these magic values, and document those instead of the raw values?
There was a problem hiding this comment.
Hmm I don't know how to reconcile that this value can be any positive integer when it's a mid rolls. Also, postroll are represented differently depending if you are using client side ads or DAI VOD and there isn't a way to get the type in the class.
bparrishMines
added
the
autosubmit
flutter/packages@8ca6416...260f381 2025-10-08 jessiewong401@gmail.com Add Versioning to Gradle 9 Deprecation Change (flutter/packages#10187) 2025-10-07 julien@delarbre.biz [camera_avfoundation] iOS: Fix crash when `enableAudio == false` by correcting guard condition (flutter/packages#9949) 2025-10-07 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.fragment:fragment from 1.8.8 to 1.8.9 in /packages/local_auth/local_auth_android/android (flutter/packages#10111) 2025-10-07 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for accessing data for an Ad (flutter/packages#9972) 2025-10-07 stuartmorgan@google.com [webview_flutter] Add Android geolocation README (flutter/packages#10166) 2025-10-07 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.guava:guava from 33.4.8-android to 33.5.0-android in /packages/espresso/android (flutter/packages#10047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3