This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
adding nil check #1072
Merged
adding nil check #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
reviewed
Jan 14, 2019
| ## 0.3.3 | ||
|
|
||
| * Fixed a crash on IOS when some of the package infos are not available. | ||
|
|
| @"packageName" : [[NSBundle mainBundle] bundleIdentifier], | ||
| @"version" : [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleShortVersionString"], | ||
| @"buildNumber" : [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleVersion"] | ||
| @"appName" : [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"] ?: @"", |
There was a problem hiding this comment.
IIUC this way the Dart side cannot tell if the property was set to an empty string or was absent.
Is it possible to use NSNull here if it's absent?
added 2 commits
January 14, 2019 09:39
amirh
reviewed
Jan 14, 2019
packages/package_info/pubspec.yaml
Outdated
| @@ -3,7 +3,7 @@ description: Flutter plugin for querying information about the application | |||
| package, such as CFBundleVersion on iOS or versionCode on Android. | |||
| author: Flutter Team <flutter-dev@googlegroups.com> | |||
| homepage: https://github.com/flutter/plugins/tree/master/packages/package_info | |||
| version: 0.3.2 | |||
| version: 0.3.3 | |||
There was a problem hiding this comment.
this should be 0.3.2+1 see: https://www.dartlang.org/tools/pub/versioning#semantic-versions
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Adding nil checks in NSDictionary and default them to NSNull to prevent crashes.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit dece9a6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding nil checks in NSDictionary and default them to NSNull to prevent crashes.
flutter/flutter#20761