Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix broken documentation link to AndroidBuildVersionCodes #1092

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

kangwang1988
Copy link
Contributor

@kangwang1988 kangwang1988 commented Jan 19, 2019

Fix broken documentation link to AndroidBuildVersionCodes

@kangwang1988 kangwang1988 changed the title Minor documentation. fix: flutter/flutter#26476 Jan 19, 2019
@kangwang1988 kangwang1988 requested a review from amirh January 19, 2019 07:25
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Please have the PR description say what the PR is doing vs have it just refer to an issue.
This can probably be: "Fix broken documentation link to AndroidBuildVersionCodes"

packages/device_info/lib/device_info.dart Outdated Show resolved Hide resolved
packages/device_info/lib/device_info.dart Outdated Show resolved Hide resolved
@kangwang1988 kangwang1988 changed the title fix: flutter/flutter#26476 Fix broken documentation link to AndroidBuildVersionCodes Jan 29, 2019
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@amirh amirh force-pushed the alf_master_fix_minor_documentation branch from 0414b32 to 8f187bf Compare January 30, 2019 19:03
@amirh amirh merged commit 009cd4a into flutter:master Jan 30, 2019
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants